-
Notifications
You must be signed in to change notification settings - Fork 372
Open
Labels
A-spec-toolArea: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)Area: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)C-enhanceCategory: an improvement or new featureCategory: an improvement or new featureE-mediumExperience: of moderate difficultyExperience: of moderate difficultyP-medium
Milestone
Description
End Goal
Enable two command-lines that lint, respectively check source formatting, across the entire post-weld codebase:
# lint (flake8)
ruff check --no-fix --show-fixes src tests
# format (black)
ruff format --check src testsStatus Quo
- EELS and EEST use different ruff rules.
- EELS doesn't use
ruff format. - EELS doesn't lint/format
./tests. - EEST needs to reformat 99 -> 79.
Sub-tasks
Pre-Switch
- BOTH: chore(tooling): agree on common post-weld ruff rules #1403
- EELS: chore(tooling): add missing code formatting checks (
ruff format --check) #1397 - EELS: Enable
ruffon all source undertests. - EEST: Consider fixing comment and docstring lines(<79) in EEST to enable a faster/smoother Switch.
At Switch
After EEST freeze & sub-tree update; PR in EELS:
- Re-format EEST code w/79.
- Update tox.ini to unify
ruffcommands.
fselmo
Metadata
Metadata
Assignees
Labels
A-spec-toolArea: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)Area: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)C-enhanceCategory: an improvement or new featureCategory: an improvement or new featureE-mediumExperience: of moderate difficultyExperience: of moderate difficultyP-medium