Skip to content

Fixed logic for test to handle cases when input exceeds wsDefaultReadLimit #32240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arnabnandikgp
Copy link

Fixes #32232

…tReadLimit

Signed-off-by: arnabnandikgp <arnabnandi2002@gmail.com>
@arnabnandikgp arnabnandikgp requested a review from fjl as a code owner July 18, 2025 18:08
@MariusVanDerWijden
Copy link
Member

I don't understand this fix, could you elaborate why this fixes the issue? Thanks for picking this up!

@fjl
Copy link
Contributor

fjl commented Jul 21, 2025

The fix disables the overLimit case for any input > 32MB. To be fair, the test is confusing. I'll find a better way to fix this.

@arnabnandikgp
Copy link
Author

The fix disables the overLimit case for any input > 32MB. To be fair, the test is confusing. I'll find a better way to fix this.

yup that is what I tried to assert through this test...earlier the function testLimit was checking if the message size limit was basically equal to the the default limit but rather I guess the essence of the test was to check on cases that have message size not only equal to the limit but also higher than that as we see here:

testLimit(ptr(wsDefaultReadLimit * 2))
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestWebsocketLargeRead times out on gh actions
3 participants