Skip to content

Emit close events from WebSocketProvider#5131

Open
afurm wants to merge 1 commit into
ethers-io:mainfrom
afurm:af/websocket-close-event
Open

Emit close events from WebSocketProvider#5131
afurm wants to merge 1 commit into
ethers-io:mainfrom
afurm:af/websocket-close-event

Conversation

@afurm
Copy link
Copy Markdown

@afurm afurm commented Apr 27, 2026

Summary

Fixes #4587.

This makes WebSocketProvider surface underlying websocket close events through the provider event API.

Changes

  • Adds optional onclose support to WebSocketLike
  • Emits provider "close" when the underlying websocket closes
  • Allows "close" as a valid provider event
  • Documents the "close" provider event
  • Adds a regression test for websocket close emission

Testing

  • npm run build-all
  • npx mocha --trace-warnings --reporter ./reporter.cjs ./lib.esm/_tests/test-providers-websocket.js
  • npx mocha --reporter ./reporter.cjs ./lib.commonjs/_tests/test-providers-websocket.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Websocket onclose event not enabled

1 participant