-
Notifications
You must be signed in to change notification settings - Fork 94
feat: Allow dynamically created custom launchers #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Allow dynamically created custom launchers #212
Conversation
We've tested out this approach on my fork and it allowed us to integrate our custom builder while benefitting from upstream changes in optimism-package worldcoin/world-chain#201 |
thanks for this contribution! overall this looks like a reasonable approach, but I'm wondering if perhaps it could simplify things if you instead published your custom launcher as a Kurtosis package, and modified the code in this package to support loading the launcher from an external package; thinking this way we could avoid having to add a new top-level argument that could only be set in code, not in a params file, breaking entrypoint parity. |
That sounds interesting, I'll explore this idea some time later. What I'd like to preserve is the ease of development though - I wouldn't want to have to redeploy a package everytime I make some local changes |
@Dzejkop understandable, that wouldn't be a great dev experience. Luckily Kurtosis supports |
This reverts commit 5c6b326.
b7f92dc
to
2694111
Compare
@@ -1,4 +1,4 @@ | |||
name: github.com/ethpandaops/optimism-package | |||
name: github.com/dzejkop/optimism-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: github.com/dzejkop/optimism-package | |
name: github.com/ethpandaops/optimism-package |
How this works
This feature allows one to specify a
custom
el/cl/builder type in the network params, e.g.which, can then be dynamically in one's own kurtosis package, e.g.
Motivation
We're setting up our own devnet using kurtosis and we're testing our own custom builder. We tried forking/vendoring the whole optimism package and extending it with our own functionality but this is very cumbersome.
I explored if it'd be possible to import
optimism-package
as a dep, run it and then add our custom builder service later, but the package either deploys with rollup boost & builder nodes or nothing at all. It's possible to setup an external builder but then we need to dynamically figure out the ip address of the host machine as it has to be known ahead of time.This approach also allows us to benefit from observability integration.