Feature/bebop estimation #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry access in case of rotational outliers)
include/bebop_odometry_estimator.h
Outdated
| */ | ||
|
|
||
| #ifndef VICON_ODOMETRY_ESTIMATOR_H | ||
| #define VICON_ODOMETRY_ESTIMATOR_H |
There was a problem hiding this comment.
Change this guard name to BEBOP_ODOMETRY_ESTIMATOR_H.
|
Thanks guys. Mainly good work. My comments are stylistic. There is nothing wrong there content-wise. Address the comments above and I will have another look after that. Note the autoformatter comment. This saves making coding style mistakes. |
|
@alexmillane thak you for the helpful comments. I made the changes you requested. Let me know if I missed anything |
|
@fgrigis @SafariLeader Hey guys was this the final code that you used for the final experiments? If so let's merge it. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.