[ga] Fixed catkin test #649
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow to use the new ROS apt key from the rosdistro repository and references the upstream change.
- Switch ROS GPG key retrieval from
wgettocurlandapt-key add - Add comment explaining the change with a link to the upstream PR
Comments suppressed due to low confidence (1)
.github/workflows/config.yml:117
- The
apt-keycommand is deprecated in newer Debian/Ubuntu releases. Consider placing the key in/usr/share/keyrings/ros-archive-keyring.gpgand updating thesources.list.d/ros-latest.listentry with asigned-byoption for better security and future compatibility.
curl -s https://raw.githubusercontent.com/ros/rosdistro/master/ros.asc | sudo apt-key add -
Contributor
Author
|
Closed by #647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ROS keys to new ones used in ros-apt-source.
ref: ros/rosdistro#46048