Skip to content

Commit 7f16464

Browse files
committed
Arg names must be uniquely named to work with Diagnostic listeners
1 parent de41e30 commit 7f16464

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

src/Platforms/Exceptionless.AspNetCore/ExceptionlessDiagnosticListener.cs

+14-12
Original file line numberDiff line numberDiff line change
@@ -6,46 +6,48 @@
66
namespace Exceptionless.AspNetCore {
77
internal sealed class ExceptionlessDiagnosticListener {
88
private readonly ExceptionlessClient _client;
9+
910
public ExceptionlessDiagnosticListener(ExceptionlessClient client) {
1011
_client = client;
1112
}
1213

1314
[DiagnosticName("Microsoft.AspNetCore.Diagnostics.HandledException")]
14-
public void OnDiagnosticHandledException(HttpContext context, Exception ex) {
15+
public void OnDiagnosticHandledException(HttpContext httpContext, Exception exception) {
1516
var contextData = new ContextData();
1617
contextData.SetSubmissionMethod("Microsoft.AspNetCore.Diagnostics.UnhandledException");
17-
contextData.Add(nameof(HttpContext), context);
18+
contextData.Add(nameof(HttpContext), httpContext);
1819

19-
ex.ToExceptionless(contextData, _client).Submit();
20+
exception.ToExceptionless(contextData, _client).Submit();
2021
}
2122

2223
[DiagnosticName("Microsoft.AspNetCore.Diagnostics.UnhandledException")]
23-
public void OnDiagnosticUnhandledException(HttpContext context, Exception ex) {
24+
public void OnDiagnosticUnhandledException(HttpContext httpContext, Exception exception) {
2425
var contextData = new ContextData();
2526
contextData.MarkAsUnhandledError();
2627
contextData.SetSubmissionMethod("Microsoft.AspNetCore.Diagnostics.HandledException");
27-
contextData.Add(nameof(HttpContext), context);
28+
contextData.Add(nameof(HttpContext), httpContext);
2829

29-
ex.ToExceptionless(contextData, _client).Submit();
30+
exception.ToExceptionless(contextData, _client).Submit();
3031
}
3132

3233
[DiagnosticName("Microsoft.AspNetCore.Hosting.UnhandledException")]
33-
public void OnHostingUnhandledException(HttpContext context, Exception ex) {
34+
public void OnHostingUnhandledException(HttpContext httpContext, Exception exception) {
3435
var contextData = new ContextData();
3536
contextData.MarkAsUnhandledError();
3637
contextData.SetSubmissionMethod("Microsoft.AspNetCore.Hosting.UnhandledException");
37-
contextData.Add(nameof(HttpContext), context);
38+
contextData.Add(nameof(HttpContext), httpContext);
3839

39-
ex.ToExceptionless(contextData, _client).Submit();
40+
exception.ToExceptionless(contextData, _client).Submit();
4041
}
4142

4243
[DiagnosticName("Microsoft.AspNetCore.MiddlewareAnalysis.MiddlewareException")]
43-
public void OnMiddlewareException(Exception ex, string name) {
44+
public void OnMiddlewareException(HttpContext httpContext, Exception exception, string name) {
4445
var contextData = new ContextData();
4546
contextData.MarkAsUnhandledError();
46-
contextData.SetSubmissionMethod(name);
47+
contextData.SetSubmissionMethod(name ?? "Microsoft.AspNetCore.MiddlewareAnalysis.MiddlewareException");
48+
contextData.Add(nameof(HttpContext), httpContext);
4749

48-
ex.ToExceptionless(contextData, _client).Submit();
50+
exception.ToExceptionless(contextData, _client).Submit();
4951
}
5052
}
5153
}

0 commit comments

Comments
 (0)