Remove Sparkpost email validation in favor of SES Auto Validation (#8826)

* Remove Sparkpost email validation in favor of SES Auto Validation

SES Auto Validation now handles email address validation at the
infrastructure level before delivery, making the app-level Sparkpost
recipient validation redundant. This removes the VerifyEmail command,
its call sites (bootstrap + email change), and the email_status_invalid
gate from may_receive_emails?.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Restore email_status_invalid gate and add tests for unverified

Keep blocking emails to addresses previously marked invalid by Sparkpost,
but allow sending to unverified addresses (which all new users will now
have since we no longer proactively validate).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: iHiD

app/commands/user/bootstrap.rb

@@ -7,7 +7,6 @@ def call
     user.auth_tokens.create!
     AwardBadgeJob.perform_later(user, :member)
     Metric::Queue.(:sign_up, user.created_at, user:)
-    User::VerifyEmail.defer(user)
 
     link_courses!
   end

app/commands/user/verify_email.rb

@@ -174,10 +174,6 @@ class User < ApplicationRecord
     after_confirmation if confirmed?
   end
 
-  after_update_commit do
-    reverify_email! if previous_changes.key?('email')
-  end
-
   # If we don't know about this record, maybe the
   # user's data record has it instead?
   def method_missing(name, *args)
@@ -339,11 +335,6 @@ def send_devise_notification(notification, *args)
     devise_mailer.send(notification, self, *args).deliver_later
   end
 
-  def reverify_email!
-    email_status_unverified!
-    User::VerifyEmail.defer(self)
-  end
-
   memoize
   def bought_course?
     course_enrollments.paid.exists?

app/models/user.rb

@@ -31,13 +31,6 @@ class User::BootstrapTest < ActiveSupport::TestCase
     assert_equal user, metric.user
   end
 
-  test "email verified for new user" do
-    user = create :user
-
-    User::VerifyEmail.expects(:defer).with(user).once
-    User::Bootstrap.(user)
-  end
-
   test "becomes attendee and subscribes to onboarding emails if paid email" do
     enrollment = create :course_enrollment, :coding_fundamentals, :paid
     user = create :user, email: enrollment.email

test/commands/user/bootstrap_test.rb

@@ -409,16 +409,6 @@ class UserTest < ActiveSupport::TestCase
     assert_equal :insider, user.flair
   end
 
-  test "email verified when email changes" do
-    user = create :user
-
-    User::VerifyEmail.expects(:defer).with(user).once
-
-    user.email = 'test@example.org'
-    user.skip_reconfirmation!
-    user.save!
-  end
-
   test "asset may receive email by default" do
     user = create :user
     assert user.may_receive_emails?
@@ -434,12 +424,18 @@ class UserTest < ActiveSupport::TestCase
     refute user.may_receive_emails?
   end
 
-  test "refute may receive email for invalid email" do
-    user = create :user, disabled_at: Time.current
-    user.email_status_invalid!
+  test "refute may receive email for invalid email status" do
+    user = create :user
+    user.data.update!(email_status: :invalid)
     refute user.may_receive_emails?
   end
 
+  test "assert may receive email for unverified email status" do
+    user = create :user
+    user.data.update!(email_status: :unverified)
+    assert user.may_receive_emails?
+  end
+
   test "refute may receive email for ghost user" do
     user = create :user, :ghost
     refute user.may_receive_emails?