-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Show the author's image in the blog #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related to this, when working on RSS I noticed that we have some posts with multiple authors (example). I wonder whether we should decide on a common format for author front-matter to allow for:
Something along the lines of: authors:
- name: Ulises Gascón
url: https://ulisesgascon.com/
- name: Express Technical Committee We could go one further and require authors to be defined in Jekyll data then referenced by ID or something (example), but this might be an annoying maintenance burden. |
Hi @rowanmanning, thank you for your suggestions. I think it is better to add github username in front matter then generate images in blog layout. |
I see much more value in using the name rather than the username in the blog (either because most blog posts are from the TC, or for aesthetic reasons), although we could still reference the author by username to fetch the image, like in the example @rowanmanning showed. |
Thanks both for your feedback. If you're happy for me to work then I could start with the following, it'd be easy to move into Post frontmatterSingle author, will display as an unlinked name only authors:
- name: Example Author Multiple authors, will display as unlinked names delimited by authors:
- name: Example Author 1
- name: Example Author 2 Authors with names and GitHub usernames, will display with a link to their GitHub profile. We'll also use authors:
- name: Example Author 1
github: exampleuser1
- name: Example Author 2
github: exampleuser2 Authors with GitHub usernames only, will display with a link to their GitHub profile with authors:
- github: exampleuser1
- github: exampleuser2 If I were an author I'd also prefer to link to my website. Up to you, but it'd be relatively easy to also support a DocsThe editing guidelines would need to change, I'm happy to write this up and outline the various options. I'd also update the existing posts to use the new format. TestingMaybe it's out of scope for this, but it should be possible to add a step to fail the GitHub Pages build if the author frontmatter is malformed. I'll leave it out for now but could open an issue if you think it'd be valuable. |
Sorry for the delay, @rowanmanning do you want to open a PR? |
No problem, yep I'm happy to do the work if you're happy with that 👍 just didn't want to go ahead if you had a different direction in mind |
As the title says, it would be great to display the author's GitHub profile picture.
The text was updated successfully, but these errors were encountered: