Skip to content

Commit 4a4a547

Browse files
committed
Merge branch 'feature/utils' into develop
2 parents 06dd3e7 + b745618 commit 4a4a547

File tree

12 files changed

+40
-39
lines changed

12 files changed

+40
-39
lines changed

build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ subprojects {
4646
implementation 'com.fasterxml.jackson.core:jackson-databind'
4747
implementation 'com.github.gavlyukovskiy:p6spy-spring-boot-starter:1.9.0'
4848
implementation 'org.springframework.retry:spring-retry'
49+
implementation 'org.springframework.data:spring-data-envers'
4950
// utils
5051

5152
// test

core/src/main/java/jshop/core/config/P6SpyConfig.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import org.springframework.context.annotation.Configuration;
1010
import org.springframework.context.annotation.Profile;
1111

12-
@Profile("dev")
1312
@Configuration
1413
public class P6SpyConfig implements MessageFormattingStrategy {
1514

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
spring:
22
jpa:
33
hibernate:
4-
ddl-auto: update
4+
ddl-auto: create-drop
5+
6+
logging:
7+
level:
8+
sql: trace

jenkins/develop-test.jenkins

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/*
12
pipeline {
23
agent any
34

@@ -16,5 +17,5 @@ pipeline {
1617
junit 'build/test-results/test/*.xml'
1718
}
1819
}
19-
20-
}
20+
}
21+
*/

jenkins/pr_open_script.jenkins

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
/*
12
pipeline {
23
agent any
34

@@ -17,3 +18,4 @@ pipeline {
1718
}
1819
}
1920
}
21+
*/

web/src/main/java/jshop/web/logging/LoggingFilter.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,15 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
4646
LoggingHttpServletRequestWrapper requestWrapper = new LoggingHttpServletRequestWrapper(httpRequest);
4747
LoggingHttpServletResponseWrapper responseWrapper = new LoggingHttpServletResponseWrapper(httpResponse);
4848

49-
chain.doFilter(requestWrapper, responseWrapper);
49+
Enumeration<String> requestHeaderNames = httpRequest.getHeaderNames();
50+
Map<String, String> requestHeaders = new HashMap<>();
5051

5152
String requestData = new String(requestWrapper.getRequestData(), Charset.defaultCharset());
5253

5354
if (httpRequest.getRequestURI().equals("/api/login")) {
5455
requestData = "Secure Info";
5556
}
5657

57-
String responseData = new String(responseWrapper.getResponseData(), Charset.defaultCharset());
58-
59-
// 로그에 기록
60-
Enumeration<String> requestHeaderNames = httpRequest.getHeaderNames();
61-
Map<String, String> requestHeaders = new HashMap<>();
62-
6358
while (requestHeaderNames.hasMoreElements()) {
6459
String header = requestHeaderNames.nextElement();
6560
if (requestHeaders.get(header) == null) {
@@ -80,6 +75,12 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
8075
.body(requestData)
8176
.build();
8277

78+
log.info("Request Log\n{}", objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(requestLog));
79+
80+
chain.doFilter(requestWrapper, responseWrapper);
81+
82+
String responseData = new String(responseWrapper.getResponseData(), Charset.defaultCharset());
83+
8384
ResponseLog responseLog = ResponseLog
8485
.builder()
8586
.id(uuid)
@@ -94,7 +95,6 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
9495
.body(responseData)
9596
.build();
9697

97-
log.info("Request Log\n{}", objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(requestLog));
9898
log.info("Response Log\n{}", objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(responseLog));
9999
}
100100

web/src/main/resources/application.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ spring:
44
datasource:
55
hikari:
66
maximum-pool-size: 20
7+
max-lifetime: 250_000
8+
p6spy:
9+
enable-logging: true
10+
multiline: true
11+
logging: slf4j
12+
tracing:
13+
include-parameter-values: true
714
jpa:
815
hibernate:
916
ddl-auto: update
@@ -66,6 +73,7 @@ spring:
6673
username: ${MYSQL_USERNAME}
6774
password: ${MYSQL_PASSWORD}
6875

76+
6977
jwt:
7078
secret: ${JWT_SECRET_KEY}
7179

web/src/main/resources/logback-spring-dev.xml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,6 @@
1010
</encoder>
1111
</appender>
1212

13-
<!-- <logger name="jdbc" level="OFF" additive="false">-->
14-
<!-- <appender-ref ref="STDOUT"/>-->
15-
<!-- </logger>-->
16-
<!-- <logger name="jdbc.sqlonly" level="DEBUG" additive="false">-->
17-
<!-- <appender-ref ref="STDOUT"/>-->
18-
<!-- </logger>-->
19-
<!-- <logger name="jdbc.sqltiming" level="OFF" additive="false">-->
20-
<!-- <appender-ref ref="STDOUT"/>-->
21-
<!-- </logger>-->
22-
<!-- <logger name="org.hibernate.SQL" level="DEBUG" additive="false">-->
23-
<!-- <appender-ref ref="STDOUT"/>-->
24-
<!-- </logger>-->
25-
2613
<root level="INFO">
2714
<appender-ref ref="STDOUT"/>
2815
</root>

web/src/main/resources/logback-spring-prod.xml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -27,20 +27,6 @@
2727
</encoder>
2828
</appender>
2929

30-
31-
<!-- <logger name="jdbc" level="OFF" additive="false">-->
32-
<!-- <appender-ref ref="FILE"/>-->
33-
<!-- </logger>-->
34-
<!-- <logger name="jdbc.sqlonly" level="DEBUG" additive="false">-->
35-
<!-- <appender-ref ref="FILE"/>-->
36-
<!-- </logger>-->
37-
<!-- <logger name="jdbc.sqltiming" level="OFF" additive="false">-->
38-
<!-- <appender-ref ref="FILE"/>-->
39-
<!-- </logger>-->
40-
<!-- <logger name="org.hibernate.SQL" level="DEBUG" additive="false">-->
41-
<!-- <appender-ref ref="FILE"/>-->
42-
<!-- </logger>-->
43-
4430
<root level="INFO">
4531
<appender-ref ref="FILE"/>
4632
<appender-ref ref="STDOUT"/>

web/src/test/java/jshop/web/acceptance/AddressAcceptanceTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import java.io.UnsupportedEncodingException;
1515
import java.util.List;
1616
import java.util.Optional;
17+
import jshop.core.config.P6SpyConfig;
1718
import jshop.core.domain.address.dto.CreateAddressResponse;
1819
import jshop.core.domain.address.entity.Address;
1920
import jshop.core.domain.address.repository.AddressRepository;
@@ -33,6 +34,7 @@
3334
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
3435
import org.springframework.boot.test.autoconfigure.web.servlet.MockMvcPrint;
3536
import org.springframework.boot.test.context.SpringBootTest;
37+
import org.springframework.context.annotation.Import;
3638
import org.springframework.http.MediaType;
3739
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
3840
import org.springframework.test.web.servlet.MockMvc;
@@ -45,6 +47,7 @@
4547
@AutoConfigureMockMvc(print = MockMvcPrint.NONE)
4648
@Transactional
4749
@DisplayName("[통합 테스트] AddressController")
50+
@Import(P6SpyConfig.class)
4851
public class AddressAcceptanceTest extends BaseTestContainers {
4952

5053
@Autowired

0 commit comments

Comments
 (0)