-
Notifications
You must be signed in to change notification settings - Fork 1
release/v0.0.6 #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release/v0.0.6 #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redis 세팅 * 쿠폰 도메인 생성 * 주문시 쿠폰이 있다면 최종 결제 금액에 계산 * 쿠폰은 다형성을 제공
* redis 분산락을 사용한 동시성 문제 해결
* 쿠폰 타입이 null일때 문제 발생 수정
* 포인트컷 수정
쿠폰 발급 동시성 문제 해결
* mysql 설정
* 레디스 추가 * 기존 application.yml 설정 제거
* 외부 의존이 필요한경우 테스트 컨테이너 베이스 클래스를 상속해 사용 * @DataJpaTest -> @AutoConfigureTestDatabase(replace = Replace.NONE) * 임베디드 DB사용 안함.
* 테스트 코드 컨벤션 통일
* 스프링 부트 설정에서 @EnableJpaAuditing가 빠져 테스트에서 추가 * coupon 없을때 취소 NPE => coupon 체크후 취소 * 상세 상품 생성 테스트 코드 오류 수정 * SpringBootTest 에서 DB를 밀어주지 않아 생기는 테스트 간섭 제거 * jpa 컨텍스트 밖에서 변경해 더티체킹이 안일어나는 오류 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제목
설명
체크리스트
연관 이슈
추가 정보