Feature/l4test enhancement #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
louisom
commented
Nov 20, 2016
louisom
commented
- Update IPC test cases
- Add KIP test cases
- Add mem test cases
jserv
reviewed
Nov 21, 2016
| int check_kipptr(L4_KernelInterfacePage_t *kip, void * ptr) | ||
| { | ||
| if (((L4_Word_t)kip + (1 << kip->KipAreaInfo.X.s) >= (L4_Word_t)ptr) | ||
| && (ptr >= (void *) kip)) |
jserv
reviewed
Nov 21, 2016
| #include "assert.h" | ||
|
|
||
| __USER_TEXT | ||
| int check_kipptr(L4_KernelInterfacePage_t *kip, void * ptr) |
There was a problem hiding this comment.
We prefer void *ptr over void * ptr.
jserv
reviewed
Nov 21, 2016
| __USER_DATA | ||
| kid_list_t kid_list[] = | ||
| { | ||
| { 0, 0, "F9", "NCKU" }, |
There was a problem hiding this comment.
F9 is an independent project from NCKU.
jserv
reviewed
Nov 21, 2016
| } kid_list_t; | ||
|
|
||
| __USER_DATA | ||
| kid_list_t kid_list[] = |
There was a problem hiding this comment.
We don't really want to implement full KernelInformation support. Use dummy array instead.
jserv
reviewed
Nov 21, 2016
| { | ||
| int i, len = strlen(msg); | ||
| /* | ||
| * TODO: Why can't we use strlen, the string memory was |
jserv
reviewed
Nov 21, 2016
| } else { | ||
| if ((L4_ErrorCode() & 0x1) == 0 || | ||
| ((L4_ErrorCode() >> 1) & 0x7) != 1) { | ||
| printf ("RCV: Incorrect error code: %s %s\n", |
jserv
reviewed
Nov 21, 2016
| @@ -0,0 +1,39 @@ | |||
| /* Copyright (c) 2002, 2003, 2007, 2010 Karlsruhe University. | |||
There was a problem hiding this comment.
You should replace the copyright notice with F9 Microkernel project since it is ARM Cortex-M specific.
jserv
reviewed
Nov 21, 2016
| #include <l4/types.h> | ||
| #include <l4/ipc.h> | ||
| #include <l4io.h> | ||
| #include <platform/cortex_m.h> |
There was a problem hiding this comment.
Is the <platform/cortex_m.h> required?
jserv
reviewed
Nov 21, 2016
| printf("test: Welcome to memtest!\n"); | ||
|
|
||
| while (max--) { | ||
| // *addr = 0x37ULL; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.