-
-
Notifications
You must be signed in to change notification settings - Fork 96
feat: add a color preview on readonly color field #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add a color preview on readonly color field #228
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 94.50% 95.75% +1.24%
==========================================
Files 8 9 +1
Lines 182 212 +30
==========================================
+ Hits 172 203 +31
+ Misses 10 9 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d156fa7 to
ac83e92
Compare
ac83e92 to
004fc56
Compare
|
@fabiocaccamo Any feedback? |
|
@obdulia-losantos sorry for the late feedback, I had not the time to try it yet, a quick feedback:
|
004fc56 to
2916fc2
Compare
|
|
@obdulia-losantos I finally tested this PR and also pushed some changes. I would like to ask you some questions:
|
|
@fabiocaccamo I fixed the tests |
|
@fabiocaccamo any comment? |



name: Color preview
about: Add a color preview on readonly color field
assignees: fabiocaccamo
Describe your changes
Added new admin mixin class,
ColorMixin, to handle color fields and display a preview of the color in the change list and in the form along with the value when needed.Note: I added the example app to check that everything works as expected, if that's the case I'll remove it before you merge it. (@fabiocaccamo)
Related issue
#91
#104
Checklist before requesting a review