-
Notifications
You must be signed in to change notification settings - Fork 2
fix: Support libraries using TargetFrameworks property #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2265fc2
fix: Support libraries using TargetFrameworks
roboz0r 4d47ccd
chore: Adding multi tfm tests
roboz0r 765ecce
chore: Address PR12 comments
roboz0r 3ca6a33
test: rewrite test to use a version which can fails (before if we dis…
MangelMaxime 6cd3e77
test: restore modified file
MangelMaxime dc2b43f
test: remove tracked packages.lock.json file
MangelMaxime 8a45142
test: try disable restore with lock file as it seems to cause issue f…
MangelMaxime cdda5f1
test: test
MangelMaxime 1aca8f3
test: try fix CI
MangelMaxime 25f8647
test: try more fixes
MangelMaxime 1e8bbc9
test: disable freezing test
MangelMaxime a9e4d65
test: try again
MangelMaxime b50b128
test: remove log + re freeze test
MangelMaxime File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,4 +13,5 @@ fixtures/ | |
bin/ | ||
Release/ | ||
MyLibrary.1.0.0.nupkg | ||
MyLibraryMultiTFM.1.0.0.nupkg | ||
"""> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks> | ||
<FablePackageType>binding</FablePackageType> | ||
</PropertyGroup> | ||
<Import Project="./../Fable.Package.SDK.Imports.props" /> | ||
</Project> |
12 changes: 12 additions & 0 deletions
12
tests/fixtures/valid/library-with-files/MyLibraryMultiTFM.fsproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks> | ||
<FablePackageType>library</FablePackageType> | ||
<PackageTags>fable-javascript</PackageTags> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<Compile Include="Entry.fs" /> | ||
</ItemGroup> | ||
<Import Project="./../../Fable.Package.SDK.Imports.props" /> | ||
</Project> |
MangelMaxime marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.