Skip to content

updated fable-library-js to ^2.0.0-beta.3#38

Merged
nojaf merged 4 commits intofable-compiler:mainfrom
laurentpayot:main
May 7, 2025
Merged

updated fable-library-js to ^2.0.0-beta.3#38
nojaf merged 4 commits intofable-compiler:mainfrom
laurentpayot:main

Conversation

@laurentpayot
Copy link
Contributor

Fixes #37 (and thoth-org/Thoth.Json#223)

Used Bun to remove the old version and add the latest beta version of fable-library-js

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only relevant if you also bump the Fable.Compiler nuget package. Those need to be in sync.

@laurentpayot
Copy link
Contributor Author

My last commit updated Fable.Compiler to version 5.0.0-alpha.13 in Directory.Packages.props.

Is that all that’s needed?

@nojaf
Copy link
Member

nojaf commented May 6, 2025

I'm not sure, did you test any of this against your own project?
Would have expected https://www.nuget.org/packages/Fable.AST/5.0.0-beta.1 to also need a bump.

@laurentpayot
Copy link
Contributor Author

laurentpayot commented May 6, 2025

I will try tomorrow tonight and let you know.

@laurentpayot
Copy link
Contributor Author

Last commit updated Fable.AST to 5.0.0-beta.1

I built vite-plugin-fable with bun install, then linked it to my project with pnpm link.
Everything seems to be working, both in dev and prod modes 🎉

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, works for me.
Thank you!

PS: never use your main branch to send PRs. I was going to bump the version as well in your PR and that isn't allowed if you use your default branch.

@nojaf nojaf merged commit 3134d11 into fable-compiler:main May 7, 2025
1 check passed
@laurentpayot
Copy link
Contributor Author

PS: never use your main branch to send PRs.

Will do. In the future, do you want me to do Fable version updates like this regularly?

@nojaf
Copy link
Member

nojaf commented May 7, 2025

Do those you need for yourself, I'd say. It might be interesting to document this process somewhere.

@laurentpayot
Copy link
Contributor Author

Well I will at least when the plugin is broken. I remember using paket for updates is out of the question for you, right?
When Fable 5 is out of alpha/beta, I will probably submit a PR and try to find the time to write some documentation.

@nojaf
Copy link
Member

nojaf commented May 7, 2025

Why would want to use paket? It is unmaintained and can break every dotnet SDK?
What advantages would this have over NuGet?

@laurentpayot
Copy link
Contributor Author

Because of paket update, amongst other reasons.
The last paket commit is from six months ago. I have seen worse in the .Net ecosystem.
Anyway don’t worry, I will stick to NuGet because I do not want to fix something that is not broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated fable-library-js

2 participants