Skip to content

Conversation

@Strum355
Copy link
Collaborator

Removes extraneous try { } catch(e) { throw e }, unwraps usage of new Promise wrapped by try catch into direct async-awaits, and some other minor formatting changes/multiline string usage/missing parameter types.

@Strum355 Strum355 requested a review from ruromero April 28, 2025 16:13
@Strum355 Strum355 force-pushed the nsc/chore-promises branch from 66d6434 to 1d1cdbb Compare April 28, 2025 16:20
@Strum355 Strum355 force-pushed the nsc/chore-promises branch from dc3f4f4 to 4825be0 Compare April 28, 2025 16:48
Copy link
Collaborator

@ruromero ruromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I only added an optional change unrelated to the purpose of this PR

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (31f46bf) to head (4081fbc).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   98.73%   98.70%   -0.04%     
==========================================
  Files          13       13              
  Lines         395      385      -10     
  Branches       53       52       -1     
==========================================
- Hits          390      380      -10     
  Misses          3        3              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Strum355 Strum355 merged commit 0715974 into fabric8-analytics:master Apr 30, 2025
2 checks passed
@ptomanRH ptomanRH added this to the v0.9.7 milestone Apr 30, 2025
@ptomanRH ptomanRH moved this from Backlog to Done in Red Hat Dependency Analytics Extension Apr 30, 2025
@ptomanRH ptomanRH modified the milestones: v0.9.7, 052025 May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants