Skip to content

Expose sundrio builder-annotations in generated bom #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shawkins opened this issue Mar 5, 2025 · 3 comments
Open

Expose sundrio builder-annotations in generated bom #6932

shawkins opened this issue Mar 5, 2025 · 3 comments

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 5, 2025

Is your task related to a problem? Please describe

To finish off quarkusio/quarkus#42991 the generated bom needs to include builder-annotations.

Describe the solution you'd like

To finish off quarkusio/quarkus#42991 the generated bom needs to include builder-annotations.

Describe alternatives you've considered

No response

Additional context

No response

@shawkins
Copy link
Contributor Author

shawkins commented Mar 5, 2025

@manusa can you confirm that quarkus doesn't want to use the bom with deps to at the very least avoid okhttp? Also I see builder-annotations is marked as provided in the pom with deps, which would make it ineligible for import anyway.

@manusa
Copy link
Member

manusa commented Mar 5, 2025

Hi @shawkins

Could you please elaborate a little bit more?

Our kubernetes-client-bom-with-deps seems to be outdated at the moment, I can see:

<include>com.squareup*:*</include>

Which shouldn't be there.

@manusa are you good with just updating the fabric8 pom have builder-annotations not at the provided scope?

I guess we can safely change the scope of our dependency and change our affected poms accordingly since this shouldn't really have impact on the users.

@shawkins
Copy link
Contributor Author

shawkins commented Mar 5, 2025

Could you please elaborate a little bit more?

My end goal is to also expose builder-annotations so that we don't have to independently manage the version in keycloak.

Quarkus is using kubernetes-client-bom (no builder-annotations), not the kubernetes-client-bom-with-deps, to create their bom. But even in the -deps bom builder-annotations is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants