Skip to content

test: enhance CRA test suite with additional edge cases and validations #17061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: enhance CRA test suite with additional edge cases and validations #17061

wants to merge 1 commit into from

Conversation

tejhande
Copy link

Summary

This PR enhances the test suite for create-react-app with additional test cases and improvements to make the suite more robust and developer-friendly.

✅ What's Added:

  • Invalid template check (--template unknown-template)
  • Invalid project name check (123invalid)
  • TypeScript-specific file check (tsconfig.json)
  • ESLint configuration presence (check for .eslintrc.json or .eslintrc.js)
  • Snapshot testing for stdout output
  • Cleaner file comparison using Set
  • Better logging before test cleanup

✅ Motivation

These changes aim to:

  • Catch more edge cases early
  • Make test failures easier to debug
  • Improve confidence in behavior for community users

Let me know if further enhancements are needed. 🚀

@tejhande
test: enhance CRA test suite with additional edge cases and validations
444f937 
### Summary

This PR enhances the test suite for `create-react-app` with additional test cases and improvements to make the suite more robust and developer-friendly.

### ✅ What's Added:

- **Invalid template check** (`--template unknown-template`)
- **Invalid project name check** (`123invalid`)
- **TypeScript-specific file check** (`tsconfig.json`)
- **ESLint configuration presence** (check for `.eslintrc.json` or `.eslintrc.js`)
- **Snapshot testing** for stdout output
- **Cleaner file comparison** using `Set`
- **Better logging** before test cleanup

### ✅ Motivation

These changes aim to:
- Catch more edge cases early
- Make test failures easier to debug
- Improve confidence in behavior for community users

Let me know if further enhancements are needed. 🚀
@facebook-github-bot
Copy link

Hi @tejhande!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@tejhande
Copy link
Author

@facebook-github-bot check

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tejhande @facebook-github-bot