Skip to content

Commit 50c9a47

Browse files
rshestfacebook-github-bot
authored andcommitted
Add missing #pragma once's in ReactCommon
Summary: ## Changelog: [Internal] - Was writing some unit tests, accidentally included `ImageProps.h` twice (once directly and once transitively) and realized that we have a handful of files without `#pragma once`. This fixes it for header files inside `ReactCommon`. Reviewed By: zeyap Differential Revision: D54258058 fbshipit-source-id: 70f4e9935304803187d1affd72ed44157b1d8fb3
1 parent 179b684 commit 50c9a47

File tree

15 files changed

+30
-0
lines changed

15 files changed

+30
-0
lines changed

packages/react-native/ReactCommon/cxxreact/ErrorUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <jsi/jsi.h>
911

1012
namespace facebook::react {

packages/react-native/ReactCommon/cxxreact/SharedProxyCxxModule.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <memory>
911

1012
#include <cxxreact/CxxModule.h>

packages/react-native/ReactCommon/react/debug/react_native_assert.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
// For recoverable conditions that can be violated by user mistake (e.g. JS
1919
// code passes an unexpected prop value), consider react_native_expect instead.
2020

21+
#pragma once
22+
2123
#include "flags.h"
2224

2325
#undef react_native_assert

packages/react-native/ReactCommon/react/debug/react_native_expect.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
// will see a helpful diagnostic (beyond a low level log). That concern is the
2121
// caller's responsibility.
2222

23+
#pragma once
24+
2325
#include "flags.h"
2426

2527
#undef react_native_expect

packages/react-native/ReactCommon/react/renderer/animations/conversions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <glog/logging.h>
911
#include <react/renderer/animations/primitives.h>
1012

packages/react-native/ReactCommon/react/renderer/components/image/ImageProps.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <react/renderer/components/view/ViewProps.h>
911
#include <react/renderer/core/PropsParserContext.h>
1012
#include <react/renderer/graphics/Color.h>

packages/react-native/ReactCommon/react/renderer/components/progressbar/android/react/renderer/components/progressbar/conversions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <folly/dynamic.h>
911
#include <react/renderer/components/rncore/Props.h>
1012
#include <react/renderer/core/propsConversions.h>

packages/react-native/ReactCommon/react/renderer/components/text/conversions.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <folly/dynamic.h>
911
#include <react/renderer/attributedstring/conversions.h>
1012
#include <react/renderer/components/text/ParagraphState.h>

packages/react-native/ReactCommon/react/renderer/runtimescheduler/ErrorUtils.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <jsi/jsi.h>
911

1012
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/scheduler/AsynchronousEventBeat.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8+
#pragma once
9+
810
#include <ReactCommon/RuntimeExecutor.h>
911
#include <react/renderer/core/EventBeat.h>
1012
#include <react/utils/RunLoopObserver.h>

0 commit comments

Comments
 (0)