Support TLS connection for Android to RN DevServer #47952
Conversation
|
Hi @unamed000! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
CLA Signed
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
left a comment
robhogan
left a comment
There was a problem hiding this comment.
This LGTM, thanks @unamed000!
...actAndroid/src/main/java/com/facebook/react/packagerconnection/PackagerConnectionSettings.kt
Outdated
Show resolved
Hide resolved
...actAndroid/src/main/java/com/facebook/react/packagerconnection/PackagerConnectionSettings.kt
Outdated
Show resolved
Hide resolved
...actAndroid/src/main/java/com/facebook/react/packagerconnection/PackagerConnectionSettings.kt
Outdated
Show resolved
Hide resolved
...actAndroid/src/main/java/com/facebook/react/packagerconnection/PackagerConnectionSettings.kt
Outdated
Show resolved
Hide resolved
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
robhogan
left a comment
robhogan
left a comment
There was a problem hiding this comment.
Looks like there are compilation errors unfortunately - see the build_android CI results. Back to you for now, but this looks good if you can fix it up.
Thanks @robhogan!! It was my mistake when copying the code from the test project over this fork/PR. I have updated the PR Also, above is the picture that i successfully integrate with my local environment via ngrok (https). |
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
# Conflicts: # packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
|
Hi @robhogan , is this PR missing something? Since it has been a long time the last time i did a new push. Thanks. |
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
6 participants
Summary:
Following this proposal: react-native-community/discussions-and-proposals#832
This PR will enable Android to be able to connect to a RN web server through TLS by setting "debug_http_tls"" as true
Currently, we're hardcoding the entire connection not having TLS. Which is different from iOS..
Changelog:
[ANDROID] [ADDED] - Add TLS connection in Android layer for Dev server.
Test Plan: