Add reverse mapping for default values in base class specialization#56032
Closed
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Closed
Add reverse mapping for default values in base class specialization#56032j-piasecki wants to merge 1 commit intofacebook:mainfrom
j-piasecki wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95933835. |
cortinico
approved these changes
Mar 10, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 11, 2026
…acebook#56032) Summary: Changelog: [Internal] When generating xml output, doxygen replaces template arguments in specialized base classes with the default values: ``` template <typename T = int> class Test : public Base<T> {}; ``` becomes ``` template <typename T = int> class Test : public Base<int> {}; ``` To work around this issue, this diff adds reverse mapping for template params in the base classes. In the above case, the map would be: `{ "int" -> "T" }`, and `int` in `Base<int>` would be replaced with T. This approach assumes that none of the default values are used directly in the base class specialization, which holds for the React Native codebase. Reviewed By: cortinico Differential Revision: D95933835
j-piasecki
force-pushed
the
export-D95933835
branch
from
4944e0e to
c8fa593
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Mar 11, 2026
…acebook#56032) Summary: Changelog: [Internal] When generating xml output, doxygen replaces template arguments in specialized base classes with the default values: ``` template <typename T = int> class Test : public Base<T> {}; ``` becomes ``` template <typename T = int> class Test : public Base<int> {}; ``` To work around this issue, this diff adds reverse mapping for template params in the base classes. In the above case, the map would be: `{ "int" -> "T" }`, and `int` in `Base<int>` would be replaced with T. This approach assumes that none of the default values are used directly in the base class specialization, which holds for the React Native codebase. Reviewed By: cortinico Differential Revision: D95933835
j-piasecki
force-pushed
the
export-D95933835
branch
from
c8fa593 to
dad39ee
Compare
…acebook#56032) Summary: Pull Request resolved: facebook#56032 Changelog: [Internal] When generating xml output, doxygen replaces template arguments in specialized base classes with the default values: ``` template <typename T = int> class Test : public Base<T> {}; ``` becomes ``` template <typename T = int> class Test : public Base<int> {}; ``` To work around this issue, this diff adds reverse mapping for template params in the base classes. In the above case, the map would be: `{ "int" -> "T" }`, and `int` in `Base<int>` would be replaced with T. This approach assumes that none of the default values are used directly in the base class specialization, which holds for the React Native codebase. Reviewed By: cortinico Differential Revision: D95933835
j-piasecki
force-pushed
the
export-D95933835
branch
from
dad39ee to
d633c63
Compare
Collaborator
|
This pull request was successfully merged by @j-piasecki in a5daece When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in a5daece. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
When generating xml output, doxygen replaces template arguments in specialized base classes with the default values:
becomes
To work around this issue, this diff adds reverse mapping for template params in the base classes. In the above case, the map would be:
{ "int" -> "T" }, andintinBase<int>would be replaced with T.This approach assumes that none of the default values are used directly in the base class specialization, which holds for the React Native codebase.
Differential Revision: D95933835