Deduplicate toObjCType function in struct serializers (#56050)#56050
Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Closed
Deduplicate toObjCType function in struct serializers (#56050)#56050christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95908134. |
meta-cla
bot
added
the
CLA Signed
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 11, 2026
Summary: Removes ~75 lines of duplicated `toObjCType` logic between `serializeConstantsStruct.js` and `serializeRegularStruct.js` by extracting it into a new shared module `serializeStructUtils.js`. The two implementations were identical except for array wrapper types (`std::vector` vs `facebook::react::LazyVector`) and type alias suffixes (`::Builder` vs none), which are now handled via a `structContext` parameter that distinguishes between `CONSTANTS` and `REGULAR` contexts. Changelog: [internal] Differential Revision: D95908134
christophpurrer
force-pushed
the
export-D95908134
branch
from
448047f to
7ae03d6
Compare
meta-codesync
bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Mar 15, 2026
Summary: Removes ~75 lines of duplicated `toObjCType` logic between `serializeConstantsStruct.js` and `serializeRegularStruct.js` by extracting it into a new shared module `serializeStructUtils.js`. The two implementations were identical except for array wrapper types (`std::vector` vs `facebook::react::LazyVector`) and type alias suffixes (`::Builder` vs none), which are now handled via a `structContext` parameter that distinguishes between `CONSTANTS` and `REGULAR` contexts. Changelog: [internal] Differential Revision: D95908134
christophpurrer
force-pushed
the
export-D95908134
branch
from
7ae03d6 to
08971c6
Compare
Summary: Removes ~75 lines of duplicated `toObjCType` logic between `serializeConstantsStruct.js` and `serializeRegularStruct.js` by extracting it into a new shared module `serializeStructUtils.js`. The two implementations were identical except for array wrapper types (`std::vector` vs `facebook::react::LazyVector`) and type alias suffixes (`::Builder` vs none), which are now handled via a `structContext` parameter that distinguishes between `CONSTANTS` and `REGULAR` contexts. Changelog: [internal] Differential Revision: D95908134
christophpurrer
force-pushed
the
export-D95908134
branch
from
08971c6 to
494af00
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in e102592 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Removes ~75 lines of duplicated
toObjCTypelogic betweenserializeConstantsStruct.jsandserializeRegularStruct.jsby extracting it into a new shared moduleserializeStructUtils.js. The two implementations were identical except for array wrapper types (std::vectorvsfacebook::react::LazyVector) and type alias suffixes (::Buildervs none), which are now handled via astructContextparameter that distinguishes betweenCONSTANTSandREGULARcontexts.Changelog: [internal]
Differential Revision: D95908134