Better profile_callable #900
Conversation
Summary: I extended profile_callable to accept a list of events of interest. In the case where this parameter is not specified, profile_callable will collect the timings of all events except those ending in " Sync". This gives us more accurate results; we no longer measure overhead from the syncs. Finally, I converted the softmax benchmark to use profile_callable for both the AIT and PT2 benchmarking. Using the same profiling function ensures we are comparing apples to apples. Differential Revision: D48252668 fbshipit-source-id: cebc4b398e525b2db755192f3c57ab298ac42faf
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48252668 |
|
Hi @int3! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
I extended profile_callable to accept a list of events of interest. In
the case where this parameter is not specified, profile_callable will collect
the timings of all events except those ending in " Sync". This gives us more
accurate results; we no longer measure overhead from the syncs.
Finally, I converted the softmax benchmark to use profile_callable for both the
AIT and PT2 benchmarking. Using the same profiling function ensures we are
comparing apples to apples.
Differential Revision: D48252668