Skip to content

Commit 3beffd9

Browse files
katrina433facebook-github-bot
authored andcommitted
read training strategy from config (#66)
Summary: * Read training strategy from config file * Add `strategy: ddp` to all existing config files * Can also pass in strategy from the terminal by `python train.py config=configs/pretraining/debug.yaml training.lightning.strategy=ddp` * Priority: terminal argument > config Pull Request resolved: #66 Test Plan: logged `self.trainer.strategy` in `FLAVAPreTrainingLightningModule` test 1 * command: `python train.py config=configs/pretraining/debug.yaml` * config: `strategy: ddp` * result: `DDPStrategy` test 2 * command: `python train.py config=configs/pretraining/debug.yaml training.lightning.strategy=deepspeed` * config: `strategy: ddp` * result: `DeepSpeedStrategy` Reviewed By: ebsmothers Differential Revision: D37124420 Pulled By: katrina433 fbshipit-source-id: a02cafba7ad784963a0c27ad543256fd5daaa417
1 parent 27a0d2e commit 3beffd9

File tree

4 files changed

+3
-1
lines changed

4 files changed

+3
-1
lines changed

examples/flava/configs/finetuning/qnli.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ training:
88
progress_bar_refresh_rate: 50
99
val_check_interval: 1000
1010
num_sanity_val_steps: 0
11+
strategy: ddp
1112
lightning_checkpoint:
1213
dirpath: "."
1314
filename: flava-{epoch:02d}-{step}

examples/flava/configs/finetuning/rendered_sst2.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ training:
88
progress_bar_refresh_rate: 50
99
val_check_interval: 100
1010
num_sanity_val_steps: 0
11+
strategy: ddp
1112
lightning_checkpoint:
1213
dirpath: "."
1314
filename: flava-{epoch:02d}-{step}

examples/flava/configs/pretraining/debug.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ training:
77
progress_bar_refresh_rate: 50
88
val_check_interval: 10000
99
num_sanity_val_steps: 0
10+
strategy: ddp
1011
lightning_checkpoint:
1112
dirpath: "."
1213
filename: flava-{epoch:02d}-{step}

examples/flava/train.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ def main():
6868
trainer = Trainer(
6969
**OmegaConf.to_container(config.training.lightning),
7070
callbacks=callbacks,
71-
strategy="ddp",
7271
)
7372
ckpt_path = config.training.lightning_load_from_checkpoint
7473

0 commit comments

Comments
 (0)