-
Notifications
You must be signed in to change notification settings - Fork 7k
Add more type hints #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more type hints #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the "-> None" hint in init is meaningless, since init always returns None and we can't use that anywhere.
The same goes for "-> str" in repr and str as we already deliberately know that these methods always return a string -> this is pointless
@JKearnsl i thought i was following pep 484 guidelines as well as what is found throughout the rest of the repo. |
We have already discussed about the |
OK. |
Hi @alexkahan, can you look into the linter issues? Thanks. |
Sorry for the delay. Should be fixed, seemed like it was having an issue with the List type hint |
Add type hints to multiple design pattern examples
Related to #373