Adding The Loop to single & page template files #21
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Dolson <design@joedolson.com>
Update version numbers
Fix broken localization in JS modules & alignment in Aspire Explorer pagination
…This can create unpredictable behaviors in the header. Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
…ying true in the footer
namithj
approved these changes
Oct 8, 2025
Signed-off-by: verlev <veerle@conimpeto.be>
joedolson
added a commit
that referenced
this pull request
Oct 9, 2025
…g to resolve TCO requirements. Signed-off-by: Joe Dolson <design@joedolson.com>
Merged
|
Closing this PR; rebuilt in #22 to resolve the DCO requirement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the_post below get_header did trigger in_the_loop() to still be false in the header, fixing aspirepress/AspireExplorer#78 partly.
The loop still didn't stop, so any title within the footer (menu) still is overwritten.
Wrapping
in a classic loop makes the loop end before the footer. Should be relevant for both single.php and page.php(ALERT 1: GH newbie here, really don't know if this is the right way to propose this edit — forked and made the changes within the fix-js-modules branch...)
(ALERT 2: didn't test with real site content, did verify all titles are being correctly filtered/not filtered by AE/main)