Fix non ascii characters being used in element IDs #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fr-Pursuit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The
unicode_slugifyfilter is used to generate slugs from the display name of things like tabs. This variant keeps special, non-ascii characters such as accented characters.However, the resulting slug is used as ID for some elements (like the content of tabbed menus), and using non-ascii characters in IDs can cause problems such as the inability to generate a URL that directly opens a specific tab. Such problems can easily be explained by the fact that IDs with special characters don't seem to be supported by the W3C.
Therefore, the ascii variant of this filter (ie:
slugify) should be used instead.Regards,
Pursuit