Skip to content

Switch main branch to Vitis and update environment for 1.0.0. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 12, 2024
Merged

Conversation

JanFSchulte
Copy link
Collaborator

Updates the tutorial notebooks to use Vitis HLS and updates the environment to work with v1.0.0 of hls4ml. Removes the docker folder as we no longer want to provide docker images for the tutorial. Note that part 7 is inoperable because the Vitis accelerator backend is not there yet.

@jmduarte jmduarte self-requested a review December 10, 2024 16:57
Copy link
Member

@jmduarte jmduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmitrevs
Copy link
Collaborator

What is the deploy-book workflow supposed to do?

@JanFSchulte
Copy link
Collaborator Author

maybe remove this github action that builds the docker container as well https://github.com/fastmachinelearning/hls4ml-tutorial/blob/main/.github/workflows/docker-publish.yml

Yep, done.

@JanFSchulte
Copy link
Collaborator Author

What is the deploy-book workflow supposed to do?

I think it builds the environment and ultimately creates https://fastmachinelearning.org/hls4ml-tutorial/README.html

@jmitrevs
Copy link
Collaborator

Does this incorporate #82?

@JanFSchulte
Copy link
Collaborator Author

Does this incorporate #82?

No, that one's separate and should be merged just after this one I guess. Unless you prefer me to pick up Sioni's changes into this PR.

@jmitrevs
Copy link
Collaborator

I think it's fine to not incorporate #82. I was just curious because I saw changes in the part5 notebook, and I was wondering if that's where they came from.

@JanFSchulte
Copy link
Collaborator Author

I picked the changes up anyway, makes since just a little bit easier.

@jmitrevs
Copy link
Collaborator

Should we merge? @jmduarte , I think you may have a change request that you need to approve, though I think the change was done.

@jmitrevs jmitrevs merged commit 433a32b into main Dec 12, 2024
2 checks passed
@jmitrevs jmitrevs deleted the vitis branch December 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants