-
Notifications
You must be signed in to change notification settings - Fork 164
Switch main branch to Vitis and update environment for 1.0.0. #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe remove this github action that builds the docker container as well https://github.com/fastmachinelearning/hls4ml-tutorial/blob/main/.github/workflows/docker-publish.yml
What is the deploy-book workflow supposed to do? |
Yep, done. |
I think it builds the environment and ultimately creates https://fastmachinelearning.org/hls4ml-tutorial/README.html |
Does this incorporate #82? |
No, that one's separate and should be merged just after this one I guess. Unless you prefer me to pick up Sioni's changes into this PR. |
I think it's fine to not incorporate #82. I was just curious because I saw changes in the part5 notebook, and I was wondering if that's where they came from. |
I picked the changes up anyway, makes since just a little bit easier. |
Should we merge? @jmduarte , I think you may have a change request that you need to approve, though I think the change was done. |
Updates the tutorial notebooks to use Vitis HLS and updates the environment to work with v1.0.0 of hls4ml. Removes the docker folder as we no longer want to provide docker images for the tutorial. Note that part 7 is inoperable because the Vitis accelerator backend is not there yet.