Skip to content

Commit bd69272

Browse files
authored
Merge pull request #1067 from vloncar/remove_extras_flow
Remove extras flow
2 parents 5241109 + 97ad08c commit bd69272

File tree

3 files changed

+10
-15
lines changed

3 files changed

+10
-15
lines changed

hls4ml/backends/catapult/catapult_backend.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import os
22
import sys
3+
from warnings import warn
34

45
import numpy as np
56

@@ -110,6 +111,7 @@ def _register_flows(self):
110111
'catapult:inplace_stream_flatten',
111112
'catapult:skip_softmax',
112113
'catapult:fix_softmax_table_size',
114+
'catapult:process_fixed_point_quantizer_layer',
113115
'infer_precision_types',
114116
]
115117
optimization_flow = register_flow('optimize', optimization_passes, requires=[init_flow], backend=self.name)
@@ -120,6 +122,7 @@ def _register_flows(self):
120122
'catapult:generate_conv_streaming_instructions',
121123
'catapult:apply_resource_strategy',
122124
'catapult:generate_conv_im2col',
125+
'catapult:apply_winograd_kernel_transformation',
123126
]
124127
catapult_types_flow = register_flow('specific_types', catapult_types, requires=[init_flow], backend=self.name)
125128

@@ -153,9 +156,8 @@ def _register_flows(self):
153156
]
154157

155158
if len(extras) > 0:
156-
extras_flow = register_flow('extras', extras, requires=[init_flow], backend=self.name)
157-
else:
158-
extras_flow = None
159+
for opt in extras:
160+
warn(f'WARNING: Optimizer "{opt}" is not part of any flow and will not be executed.')
159161

160162
ip_flow_requirements = [
161163
'optimize',
@@ -164,10 +166,8 @@ def _register_flows(self):
164166
quantization_flow,
165167
optimization_flow,
166168
catapult_types_flow,
167-
extras_flow,
168169
template_flow,
169170
]
170-
ip_flow_requirements = list(filter(None, ip_flow_requirements))
171171

172172
self._default_flow = register_flow('ip', None, requires=ip_flow_requirements, backend=self.name)
173173

hls4ml/backends/quartus/quartus_backend.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ def _register_flows(self):
5555
'quartus:transform_types',
5656
'quartus:register_bram_weights',
5757
'quartus:apply_resource_strategy',
58+
'quartus:generate_conv_im2col',
5859
'quartus:apply_winograd_kernel_transformation',
5960
]
6061
quartus_types_flow = register_flow('specific_types', quartus_types, requires=[init_flow], backend=self.name)
@@ -103,9 +104,8 @@ def _register_flows(self):
103104
]
104105

105106
if len(extras) > 0:
106-
extras_flow = register_flow('extras', extras, requires=[init_flow], backend=self.name)
107-
else:
108-
extras_flow = None
107+
for opt in extras:
108+
warn(f'WARNING: Optimizer "{opt}" is not part of any flow and will not be executed.')
109109

110110
ip_flow_requirements = [
111111
'optimize',
@@ -114,10 +114,8 @@ def _register_flows(self):
114114
quantization_flow,
115115
optimization_flow,
116116
quartus_types_flow,
117-
extras_flow,
118117
template_flow,
119118
]
120-
ip_flow_requirements = list(filter(None, ip_flow_requirements))
121119

122120
self._default_flow = register_flow('ip', None, requires=ip_flow_requirements, backend=self.name)
123121

hls4ml/backends/vivado/vivado_backend.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,8 @@ def _register_flows(self):
147147
]
148148

149149
if len(extras) > 0:
150-
extras_flow = register_flow('extras', extras, requires=[init_flow], backend=self.name)
151-
else:
152-
extras_flow = None
150+
for opt in extras:
151+
warn(f'WARNING: Optimizer "{opt}" is not part of any flow and will not be executed.')
153152

154153
ip_flow_requirements = [
155154
'optimize',
@@ -158,10 +157,8 @@ def _register_flows(self):
158157
quantization_flow,
159158
optimization_flow,
160159
vivado_types_flow,
161-
extras_flow,
162160
template_flow,
163161
]
164-
ip_flow_requirements = list(filter(None, ip_flow_requirements))
165162

166163
self._default_flow = register_flow('ip', None, requires=ip_flow_requirements, backend=self.name)
167164

0 commit comments

Comments
 (0)