Skip to content

VivadoAccelerator complete build test#1451

Draft
marco66colombo wants to merge 8 commits intofastmachinelearning:mainfrom
marco66colombo:vivadoaccelerator-full-synth
Draft

VivadoAccelerator complete build test#1451
marco66colombo wants to merge 8 commits intofastmachinelearning:mainfrom
marco66colombo:vivadoaccelerator-full-synth

Conversation

@marco66colombo
Copy link
Copy Markdown
Contributor

@marco66colombo marco66colombo commented Mar 12, 2026

Description

This is a draft PR and a CI experiment.

Goal: verify that we can run the end-to-end VivadoAccelerator build flow in CI for at least one Keras API test.

This is a first step toward extending CI coverage to analogous end-to-end flows for Vitis backends, building on:

For now, this PR only checks one case so we can validate the workflow.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify): CI/testing workflow experiment (draft)

Tests

This PR is intentionally limited to one small CI synthesis test.

What is tested:

  • New test file introduced in this PR: test/pytest/test_keras_api_vivadoacc.py.
  • VivadoAccelerator build flow on one adapted test case (test_dense) from test_keras_api.

Test Configuration:

  • Backend: VivadoAccelerator
  • Test file: test/pytest/test_keras_api_vivadoacc.py (adapted from test_keras_api)

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@marco66colombo marco66colombo added the please test Trigger testing by creating local PR branch label Mar 12, 2026
@marco66colombo marco66colombo added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Mar 16, 2026
@marco66colombo marco66colombo changed the title VivadoAccelerator full synthesis tests VivadoAccelerator complete build test Mar 16, 2026
Comment thread test/pytest/conftest.py
'VivadoAccelerator': {
'csim': False,
'synth': True,
'cosim': False,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd set it to True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please test Trigger testing by creating local PR branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants