fix crash: commit on focus out

eagleoflqj · eagleoflqj · commit 085a54acb34d · 2024-10-20T14:12:26.000-04:00
diff --git a/iosfrontend/iosfrontend.cpp b/iosfrontend/iosfrontend.cpp
@@ -25,8 +25,11 @@ void IosFrontend::focusIn(id client) {
 }
 
 void IosFrontend::focusOut() {
-    ic_->setClient(nil);
     ic_->focusOut();
+    // Extracting client from nil crashes on Swift, so it has to be put after
+    // ic_->focusOut, although commit on focus out doesn't work on iOS (even if
+    // commit inside viewWillDisappear)
+    ic_->setClient(nil);
 }
 
 IosInputContext::IosInputContext(IosFrontend *frontend,

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,11 @@ void IosFrontend::focusIn(id client) {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`void IosFrontend::focusOut() {`
`28`		`- ic_->setClient(nil);`
`29`	`28`	`ic_->focusOut();`
	`29`	`+ // Extracting client from nil crashes on Swift, so it has to be put after`
	`30`	`+ // ic_->focusOut, although commit on focus out doesn't work on iOS (even if`
	`31`	`+ // commit inside viewWillDisappear)`
	`32`	`+ ic_->setClient(nil);`
`30`	`33`	`}`
`31`	`34`
`32`	`35`	`IosInputContext::IosInputContext(IosFrontend *frontend,`