write clipboard on ^C and ^X (#42)

Author: eagleoflqj

page/keycode.ts

@@ -1,6 +1,8 @@
 import { getInputElement } from './focus'
 import Module from './module'
 
+const isApple = navigator.userAgent.includes('Mac OS X')
+
 function extract(event: KeyboardEvent): [string, string, number] | undefined {
   const { key, code, shiftKey, altKey, ctrlKey, metaKey } = event
   // Host IME
@@ -17,14 +19,22 @@ export function processKey(key: string, code: string, modifiers: number, isRelea
 }
 
 export function keyEvent(event: KeyboardEvent) {
-  if (!getInputElement()) {
+  const input = getInputElement()
+  if (!input) {
     return
   }
   const extracted = extract(event)
   if (!extracted) {
     return
   }
   const isRelease = event.type === 'keyup'
+  // Write clipboard for Ctrl/Cmd + C/X
+  if (!isRelease && ['c', 'x'].includes(extracted[0]) && ((isApple && extracted[2] === (1 << 6)) || (!isApple && extracted[2] === (1 << 2)))) {
+    const selectedText = input.value.substring(input.selectionStart ?? 0, input.selectionEnd ?? 0)
+    if (selectedText) {
+      Module.ccall('write_clipboard', 'void', ['string'], [selectedText])
+    }
+  }
   if (processKey(...extracted, isRelease)) {
     event.preventDefault()
   }

src/fcitx.cpp

@@ -1,3 +1,4 @@
+#include "../fcitx5/src/modules/clipboard/clipboard_public.h"
 #include "../wasmfrontend/wasmfrontend.h"
 #include "../webkeyboard/webkeyboard.h"
 #include "event_js.h"
@@ -18,6 +19,7 @@ namespace fcitx {
 std::unique_ptr<Instance> instance;
 WasmFrontend *frontend;
 WebKeyboard *ui;
+AddonInstance *clipboard;
 
 void notify_main_async(const std::string &str);
 
@@ -142,6 +144,10 @@ EMSCRIPTEN_KEEPALIVE void scroll(int start, int count) {
     ui->scroll(start, count);
 }
 
+EMSCRIPTEN_KEEPALIVE void write_clipboard(const char *text) {
+    clipboard->call<IClipboard::setClipboardV2>("", text, false);
+}
+
 EMSCRIPTEN_KEEPALIVE void init(const char *locale, bool worker, bool touch) {
     if (instance) {
         return;
@@ -175,6 +181,7 @@ EMSCRIPTEN_KEEPALIVE void init(const char *locale, bool worker, bool touch) {
     instance->initialize(); // Unnecessary to call exec.
     frontend = dynamic_cast<WasmFrontend *>(addonMgr.addon("wasmfrontend"));
     ui = dynamic_cast<WebKeyboard *>(addonMgr.addon("webkeyboard"));
+    clipboard = addonMgr.addon("clipboard", true);
 }
 
 EMSCRIPTEN_KEEPALIVE void reload(const char *locale, bool touch) {

tests/test-clipboard.spec.ts

@@ -0,0 +1,53 @@
+import type { Page } from '@playwright/test'
+import { expect, test } from '@playwright/test'
+import { browserName, expectPanelHidden, init } from './util'
+
+function openClipboard(page: Page) {
+  return page.keyboard.press('Control+;')
+}
+
+test('Clipboard', async ({ page }) => {
+  test.skip(process.platform === 'linux' && browserName(page) === 'webkit')
+  await init(page)
+  const CONTROL = process.platform === 'darwin' ? 'Meta' : 'Control'
+
+  const textarea = page.locator('textarea')
+  await textarea.click()
+  await textarea.fill('abc')
+
+  // Cut
+  await page.keyboard.down('Shift')
+  await page.keyboard.press('ArrowLeft')
+  await page.keyboard.up('Shift')
+  await page.keyboard.down(CONTROL)
+  await page.keyboard.press('x')
+  await page.keyboard.up(CONTROL)
+
+  // Copy
+  await page.keyboard.down('Shift')
+  await page.keyboard.press('ArrowLeft')
+  await page.keyboard.press('ArrowLeft')
+  await page.keyboard.up('Shift')
+  await page.keyboard.down(CONTROL)
+  await page.keyboard.press('c')
+  await page.keyboard.up(CONTROL)
+
+  await openClipboard(page)
+  const text = page.locator('.fcitx-text')
+  const auxDown = page.locator('.fcitx-aux-down')
+  await expect(text).toHaveCount(2)
+  await expect(text.nth(0)).toHaveText('ab')
+  await expect(text.nth(1)).toHaveText('c')
+  await expect(auxDown).not.toBeVisible()
+
+  await page.keyboard.press('2')
+  await expect(textarea).toHaveValue('c')
+
+  await openClipboard(page)
+  await page.keyboard.press('Backspace')
+  await expectPanelHidden(page)
+
+  await openClipboard(page)
+  await expect(page.locator('.fcitx-aux-down')).toHaveText('No clipboard history.')
+  await expect(text).toHaveCount(0)
+})

tests/util.ts

@@ -8,6 +8,10 @@ export async function init(page: Page) {
   })
 }
 
+export function browserName(page: Page) {
+  return page.context().browser()!.browserType().name()
+}
+
 export async function getBox(locator: Locator) {
   return (await locator.boundingBox())!
 }