support password input

Author: eagleoflqj

page/focus.ts

@@ -42,7 +42,8 @@ export function focus() {
     redrawCaret({ target: input })
   }
   originalSpellCheck = input.spellcheck
-  Module.ccall('focus_in', 'void', [], [])
+  const isPassword = input.tagName === 'INPUT' && input.type === 'password'
+  Module.ccall('focus_in', 'void', ['bool'], [isPassword])
 }
 
 export function blur() {

src/fcitx.cpp

@@ -39,7 +39,9 @@ static void answerCandidateAction(ActionableCandidateList *actionableList,
 
 extern "C" {
 
-EMSCRIPTEN_KEEPALIVE void focus_in() { frontend->focusIn(); }
+EMSCRIPTEN_KEEPALIVE void focus_in(bool isPassword) {
+    frontend->focusIn(isPassword);
+}
 
 EMSCRIPTEN_KEEPALIVE void focus_out() { frontend->focusOut(); }
 

tests/test-generic.spec.ts

@@ -37,3 +37,23 @@ test('keyboard-th', async ({ page }) => {
   }
   await expect(textarea).toHaveValue('สวัสดี')
 })
+
+test('Password', async ({ page }) => {
+  await init(page)
+
+  const textarea = page.locator('textarea')
+  const input = page.locator('input')
+  input.evaluate((el: HTMLInputElement) => el.type = 'password')
+  await page.evaluate(() => {
+    window.fcitx.setInputMethods(['keyboard-us', 'keyboard-th'])
+    window.fcitx.setCurrentInputMethod('keyboard-th')
+  })
+
+  await input.click()
+  await page.keyboard.press('l')
+  await expect(input).toHaveValue('l')
+
+  await textarea.click()
+  await page.keyboard.press('l')
+  await expect(textarea).toHaveValue('ส')
+})

wasmfrontend/wasmfrontend.cpp

@@ -14,7 +14,7 @@ WasmFrontend::WasmFrontend(Instance *instance)
     // Make mostRecentInputContext not null so that current IM info can be
     // retrieved on load finish, even if no DOM element can be actually focused
     // (e.g. when focusing on address bar).
-    focusIn();
+    focusIn(false);
 }
 
 void WasmFrontend::createInputContext() {
@@ -28,7 +28,14 @@ bool WasmFrontend::keyEvent(const Key &key, bool isRelease) {
     return event.accepted();
 }
 
-void WasmFrontend::focusIn() { ic_->focusIn(); }
+void WasmFrontend::focusIn(bool isPassword) {
+    CapabilityFlags flags = CapabilityFlag::Preedit;
+    if (isPassword) {
+        flags |= CapabilityFlag::Password;
+    }
+    ic_->setCapabilityFlags(flags);
+    ic_->focusIn();
+}
 
 void WasmFrontend::focusOut() { ic_->focusOut(); }
 
@@ -37,8 +44,6 @@ void WasmFrontend::resetInput() { ic_->reset(); }
 WasmInputContext::WasmInputContext(WasmFrontend *frontend,
                                    InputContextManager &inputContextManager)
     : InputContext(inputContextManager, ""), frontend_(frontend) {
-    CapabilityFlags flags = CapabilityFlag::Preedit;
-    setCapabilityFlags(flags);
     created();
 }
 

wasmfrontend/wasmfrontend.h

@@ -23,7 +23,7 @@ class WasmFrontend : public AddonInstance {
 
     void createInputContext();
     bool keyEvent(const Key &key, bool isRelease);
-    void focusIn();
+    void focusIn(bool isPassword);
     void focusOut();
     void resetInput();