Skip to content

fixed problem with user options when show method is called #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixed problem with user options when show method is called #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/baguetteBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@

buildOverlay();
removeFromCache(selector);
setOptions(userOptions);
return bindImageClickListeners(selector, userOptions);
}

Expand Down Expand Up @@ -384,6 +385,9 @@
// Fill options object
for (var item in defaults) {
options[item] = defaults[item];
if (!options[item]) {
options[item] = defaults[item];
}
Comment on lines 387 to +390
Copy link
Owner

@feimosi feimosi Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is an old PR, but can you explain what it's fixing? Maybe I'm missing something, but I don't see how this code changes anything by assigning the same value twice

if (typeof newOptions[item] !== 'undefined') {
options[item] = newOptions[item];
}
Expand Down