Case insensitive domain matching

Author: matthiask

.pre-commit-config.yaml

@@ -19,7 +19,7 @@ repos:
       - id: django-upgrade
         args: [--target-version, "4.2"]
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: "v0.8.6"
+    rev: "v0.9.4"
     hooks:
       - id: ruff
         args: [--unsafe-fixes]

CHANGELOG.rst

@@ -5,6 +5,9 @@ Change log
 Next version
 ~~~~~~~~~~~~
 
+- Changed host name matching to be case insensitive.
+
+
 0.4 (2024-11-12)
 ~~~~~~~~~~~~~~~~
 

feincms3_language_sites/middleware.py

@@ -46,7 +46,7 @@ def middleware(request):
                 else HttpResponsePermanentRedirect
             )
             return redirect_class(
-                f'{protocol}://{request.site["host"]}{request.get_full_path()}'
+                f"{protocol}://{request.site['host']}{request.get_full_path()}"
             )
 
         return get_response(request)

feincms3_language_sites/models.py

@@ -22,9 +22,9 @@ def site_for_host(host):
     for language_code, site in settings.SITES.items():
         site.setdefault("language_code", language_code)
         if "host_re" in site:
-            if re.search(site["host_re"], host):
+            if re.search(site["host_re"], host, re.I):
                 return site
-        elif site["host"] == host:
+        elif site["host"].lower() == host.lower():
             return site
     return None
 

tests/testapp/test_feincms3.py

@@ -45,6 +45,20 @@ def test_400(self):
         )
         self.assertEqual(self.client.get("/de/").status_code, 400)
 
+    @override_settings(SITES={"de": {"host": "blub.example.com"}})
+    def test_case_insensitive(self):
+        page = Page.objects.create(
+            title="home",
+            slug="home",
+            path="/de/",
+            static_path=True,
+            language_code="de",
+            is_active=True,
+        )
+        response = self.client.get("/de/", headers={"host": "Blub.Example.Com"})
+        self.assertContains(response, "home - testapp")
+        self.assertEqual(page.get_absolute_url(), "http://blub.example.com/de/")
+
 
 @override_settings(
     MIDDLEWARE=settings.MIDDLEWARE