Skip to content

Commit 5a854a5

Browse files
WevesYour Name
authored andcommitted
Try to reduce memory usage on group sync (onyx-dot-app#4678)
1 parent 2e0497b commit 5a854a5

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

backend/ee/onyx/external_permissions/google_drive/group_sync.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ class FolderInfo(BaseModel):
3434
permissions: list[GoogleDrivePermission]
3535

3636

37-
def _get_all_folders(google_drive_connector: GoogleDriveConnector) -> list[FolderInfo]:
37+
def _get_all_folders(
38+
google_drive_connector: GoogleDriveConnector, skip_folders_without_permissions: bool
39+
) -> list[FolderInfo]:
3840
"""Have to get all folders since the group syncing system assumes all groups
3941
are returned every time.
4042
@@ -73,6 +75,9 @@ def _get_all_folders(google_drive_connector: GoogleDriveConnector) -> list[Folde
7375
for permission in raw_permissions
7476
]
7577

78+
if not permissions and skip_folders_without_permissions:
79+
continue
80+
7681
all_folders.append(
7782
FolderInfo(
7883
id=folder_id,
@@ -286,7 +291,10 @@ def gdrive_group_sync(
286291
)
287292

288293
# Get all folder permissions
289-
folder_info = _get_all_folders(google_drive_connector)
294+
folder_info = _get_all_folders(
295+
google_drive_connector=google_drive_connector,
296+
skip_folders_without_permissions=True,
297+
)
290298

291299
# Map group emails to their members
292300
group_email_to_member_emails_map = _map_group_email_to_member_emails(

0 commit comments

Comments
 (0)