fix(cli): add airgapped checks to all external FDR/Venus service calls during fern generate #11596
+29
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing fern generate This ensures that in air-gapped environments, external service calls are skipped to prevent network errors during docs generation and SDK generation. Changes: - publishDocs.ts: Add airgapped detection and skip FDR calls for docs registration, API registration, Python docs generation, and final docs publishing - registerApi.ts: Add airgapped detection and skip FDR API registration - runRemoteGenerationForGenerator.ts: Add airgapped detection and skip Venus org lookup, FDR API registration, semantic version computation, and dynamic IR uploads Co-Authored-By: Sandeep Dinesh <sandeep@buildwithfern.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the title
…orkspace-runner Co-Authored-By: Sandeep Dinesh <sandeep@buildwithfern.com>
Co-Authored-By: Sandeep Dinesh <sandeep@buildwithfern.com>
… lookups - Remove airgapped checks that skip FDR calls (registerApiDefinition, startDocsRegister, finishDocsRegister, etc.) since these should work with local FDR via DEFAULT_FDR_ORIGIN - Keep airgapped check for Venus organization lookup (no local Venus server) - Keep airgapped check for Python docs generation (external service) - FDR calls will now properly use the local FDR server in self-hosted environments Co-Authored-By: Sandeep Dinesh <sandeep@buildwithfern.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs: Slack thread about airgapped environment failures
Fixes the "FDR registerApiDefinition failed: fetch failed" error that occurs when running
fern generate --docsin air-gapped/self-hosted environments.Revised Approach: After discussion, the fix was updated to keep FDR calls working (they should use the local FDR server via
DEFAULT_FDR_ORIGIN) and only skip external services that don't have local equivalents.Changes Made
startLibraryDocsGeneration) - this external service has no local equivalent@fern-api/lazy-fern-workspacedependency to remote-workspace-runnerWhat's NOT skipped: FDR calls (registerApiDefinition, startDocsRegister, finishDocsRegister, etc.) are NOT skipped because they should work with the local FDR server when
DEFAULT_FDR_ORIGINis properly configured.Testing
pnpm run check,pnpm format)Human Review Checklist
DEFAULT_FDR_ORIGINis properly set in self-hosted environments to point to local FDR serverregisterApi.tswas reverted to original (no airgapped checks) since it only makes FDR callsLink to Devin run: https://app.devin.ai/sessions/7aca72cdf3e44a27878b2f9655970f4e
Requested by: Sandeep Dinesh (@thesandlord)