Fix the iterators example. #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ferrous-systems-rust-exercises with
|
| Latest commit: |
4910285
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c9b3921e.ferrous-systems-rust-exercises.pages.dev |
| Branch Preview URL: | https://fixes.ferrous-systems-rust-exercises.pages.dev |
Simplified the solution and tidied up some of the exercise text whilst I was here. Closes #197
Member
Author
|
Force pushed after I found some typos I'd made. Also, I replaced "turbo fish" with "turbofish" as per the docs. |
listochkin
reviewed
Apr 24, 2025
Comment on lines
14
to
16
| .fold(0, |acc, elem| acc + elem); | ||
| // Also works | ||
| //.sum::<i32>(); |
Member
There was a problem hiding this comment.
I would simply put .sum(); here. Unlike filter and map that are popular, fold is not used too often. Half of Itertools methods are fold variants with more descriptive methods. May as well call sum because we work with numbers here. Turbofish is not needed, because there's i32 on line 9 already.
Suggested change
| .fold(0, |acc, elem| acc + elem); | |
| // Also works | |
| //.sum::<i32>(); | |
| .sum(); |
Member
Author
There was a problem hiding this comment.
Good idea. Also updated the text above to match, and the solution.
Member
Author
There was a problem hiding this comment.
11 | let result = reader.lines()
| ^^^^^^
...
15 | .sum();
| --- type must be known at this point
oops
listochkin
approved these changes
Apr 24, 2025
Member
Author
|
I have appeased the type checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the solution and tidied up some of the exercise text whilst I was here.
Closes #197