add more logs for learning #2
Conversation
There was a problem hiding this comment.
Hey, thanks for your contribution!
The title says that you want to add logs for learning, however, you also made some other changes that are probably unintentional (such as changing the vapid keys, some blank spaces, etc.).
If you want to merge this PR, I'd suggest you undo these changes first. I would also appreciate if you could make the logs more verbose by stating what you are logging together with the data.
| notifications.push(webpush.sendNotification(subscription, JSON.stringify(notification))); | ||
| console.log(`sub:${subscription}`); | ||
| const options = { | ||
| proxy: 'http://localhost:7890', |
There was a problem hiding this comment.
Why did you add this? Will this work for others as well?
There was a problem hiding this comment.
it is a example for people need a proxy :)
| @@ -1,7 +1,6 @@ | |||
| self.addEventListener('push', (e) => { | |||
| const data = e.data.json(); | |||
| self.registration.showNotification(data.title, { | |||
| body: data.body, | |||
| icon: data.icon, | |||
There was a problem hiding this comment.
Why did you remove these options?
There was a problem hiding this comment.
I debug: data.boy add data.icon is null
No description provided.