Fixed an infinite iteration in the Quick Access folder.

Author: 0x5bfa

src/Files.App.CsWin32/NativeMethods.txt

@@ -225,3 +225,4 @@ QITIPF_FLAGS
 GetKeyboardState
 MapVirtualKey
 GetKeyboardLayout
+S_FALSE

src/Files.App.Storage/Storables/WindowsStorage/WindowsFolder.cs

@@ -44,26 +44,23 @@ public IAsyncEnumerable<IStorableChild> GetItemsAsync(StorableType type = Storab
 			List<IStorableChild> childItems = [];
 
 			IShellItem* pChildShellItem = null;
-			while (pEnumShellItems.Get()->Next(1, &pChildShellItem).Succeeded && pChildShellItem is not null)
+			while ((hr = pEnumShellItems.Get()->Next(1, &pChildShellItem)) == HRESULT.S_OK)
 			{
-				cancellationToken.ThrowIfCancellationRequested();
+				bool isFolder = pChildShellItem->GetAttributes(SFGAO_FLAGS.SFGAO_FOLDER, out var dwAttributes).Succeeded && dwAttributes is SFGAO_FLAGS.SFGAO_FOLDER;
 
-				bool isFolder = pChildShellItem->GetAttributes(SFGAO_FLAGS.SFGAO_FOLDER, out var returnedAttributes).Succeeded && returnedAttributes == SFGAO_FLAGS.SFGAO_FOLDER;
-
-				if (type is StorableType.File && !isFolder)
+				if (type.HasFlag(StorableType.File) && !isFolder)
 				{
 					childItems.Add(new WindowsFile(pChildShellItem));
 				}
-				else if (type is StorableType.Folder && isFolder)
+				else if (type.HasFlag(StorableType.Folder) && isFolder)
 				{
 					childItems.Add(new WindowsFolder(pChildShellItem));
 				}
-				else
-				{
-					continue;
-				}
 			}
 
+			if (hr.ThrowIfFailedOnDebug().Failed)
+				return Enumerable.Empty<IStorableChild>().ToAsyncEnumerable();
+
 			return childItems.ToAsyncEnumerable();
 		}
 	}

src/Files.App.Storage/Storables/WindowsStorage/WindowsStorableHelpers.Shell.cs

@@ -33,10 +33,9 @@ public unsafe static HRESULT GetPropertyValue<TValue>(this IWindowsStorable stor
 			}
 			if (typeof(TValue) == typeof(bool))
 			{
-				bool propertyValue = false;
-				hr = pShellItem2.Get()->GetBool(propertyKey, out var fPropertyValue);
-				propertyValue = fPropertyValue;
-				value = Unsafe.As<bool, TValue>(ref propertyValue);
+				bool fPropertyValue = false;
+				hr = pShellItem2.Get()->GetBool(&propertyKey, (BOOL*)&fPropertyValue);
+				value = Unsafe.As<bool, TValue>(ref fPropertyValue);
 
 				return hr;
 			}

src/Files.App/ViewModels/UserControls/Widgets/QuickAccessWidgetViewModel.cs

@@ -72,20 +72,20 @@ public Task RefreshWidgetAsync()
 
 				Items.Clear();
 
-				//await foreach (IWindowsStorable folder in HomePageContext.HomeFolder.GetQuickAccessFolderAsync(default))
-				//{
-				//	folder.GetPropertyValue<bool>("System.Home.IsPinned", out var isPinned);
-				//	folder.TryGetShellTooltip(out var tooltip);
-
-				//	Items.Insert(
-				//		Items.Count,
-				//		new WidgetFolderCardItem(
-				//			folder,
-				//			folder.GetDisplayName(SIGDN.SIGDN_PARENTRELATIVEFORUI),
-				//			isPinned,
-				//			tooltip ?? string.Empty));
-				//}
-			});
+				await foreach (IWindowsStorable folder in HomePageContext.HomeFolder.GetQuickAccessFolderAsync(default))
+				{
+					folder.GetPropertyValue<bool>("System.Home.IsPinned", out var isPinned);
+					folder.TryGetShellTooltip(out var tooltip);
+
+					Items.Insert(
+						Items.Count,
+						new WidgetFolderCardItem(
+							folder,
+							folder.GetDisplayName(SIGDN.SIGDN_PARENTRELATIVEFORUI),
+							isPinned,
+							tooltip ?? string.Empty));
+				}
+			}); 
 		}
 
 		public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCardItem item, bool isPinned, bool isFolder = false)