Conversation
0x5bfa
reviewed
Feb 4, 2026
Member
0x5bfa
left a comment
There was a problem hiding this comment.
@yaira2 We should try custom instructions of Copilot code review instead for this. https://docs.github.com/en/copilot/how-tos/configure-custom-instructions/add-repository-instructions#enabling-or-disabling-custom-instructions-for-copilot-code-review
Member
|
See my previous review, or you won't try? |
Member
Author
|
I addressed your code comments, is there something else? |
Member
|
Add a GitHub Actions workflow that runs on pull requests to detect changes to .resw files under the Strings folder that are not en-US. The job lists changed files against the base ref, filters for non-en-US .resw files, and posts a comment on the PR (unless the author is crowdin[bot]) asking authors to revert and use Crowdin for translations. This prevents accidental direct edits to localized resource files. Use PR repo info to detect forks Replace the PR author-based check with a repo-origin check in the pr-resource-check workflow. The step was renamed to "Get PR branch info" and now exposes pr_head_repo and pr_base_repo from the pull_request payload. The comment step condition now requires pr_head_repo == pr_base_repo (i.e. not a fork) alongside the existing file-detection count check, instead of excluding a specific bot author. Update pr-resource-check.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub Actions workflow that runs on pull requests to detect changes to .resw files under the Strings folder that are not en-US. The job lists changed files against the base ref, filters for non-en-US .resw files, and posts a comment on the PR (unless the author is crowdin[bot]) asking authors to revert and use Crowdin for translations. This prevents accidental direct edits to localized resource files.