Skip to content

GitHub: Add PR check for non-en-US resource changes#18127

Merged
yair100 merged 1 commit intomainfrom
ya/en-us
Feb 12, 2026
Merged

GitHub: Add PR check for non-en-US resource changes#18127
yair100 merged 1 commit intomainfrom
ya/en-us

Conversation

@yair100
Copy link
Member

@yair100 yair100 commented Feb 4, 2026

Add a GitHub Actions workflow that runs on pull requests to detect changes to .resw files under the Strings folder that are not en-US. The job lists changed files against the base ref, filters for non-en-US .resw files, and posts a comment on the PR (unless the author is crowdin[bot]) asking authors to revert and use Crowdin for translations. This prevents accidental direct edits to localized resource files.

@yair100 yair100 requested a review from 0x5bfa February 4, 2026 16:42
@yair100 yair100 added the ready for review Pull requests that are ready for review label Feb 4, 2026
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yair100 yair100 requested a review from 0x5bfa February 10, 2026 15:42
@0x5bfa
Copy link
Member

0x5bfa commented Feb 10, 2026

See my previous review, or you won't try?

@yair100
Copy link
Member Author

yair100 commented Feb 10, 2026

I addressed your code comments, is there something else?

@0x5bfa
Copy link
Member

0x5bfa commented Feb 10, 2026

Add a GitHub Actions workflow that runs on pull requests to detect changes to .resw files under the Strings folder that are not en-US. The job lists changed files against the base ref, filters for non-en-US .resw files, and posts a comment on the PR (unless the author is crowdin[bot]) asking authors to revert and use Crowdin for translations. This prevents accidental direct edits to localized resource files.

Use PR repo info to detect forks

Replace the PR author-based check with a repo-origin check in the pr-resource-check workflow. The step was renamed to "Get PR branch info" and now exposes pr_head_repo and pr_base_repo from the pull_request payload. The comment step condition now requires pr_head_repo == pr_base_repo (i.e. not a fork) alongside the existing file-detection count check, instead of excluding a specific bot author.

Update pr-resource-check.yml
@yair100 yair100 merged commit ac1c1a3 into main Feb 12, 2026
10 checks passed
@yair100 yair100 deleted the ya/en-us branch February 12, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants