Skip to content

Comments

Code Quality: Avoid redownloading Satori package#18148

Merged
yair100 merged 2 commits intomainfrom
ya/Satori
Feb 12, 2026
Merged

Code Quality: Avoid redownloading Satori package#18148
yair100 merged 2 commits intomainfrom
ya/Satori

Conversation

@yair100
Copy link
Member

@yair100 yair100 commented Feb 11, 2026

Add date-based archive path and flags to skip downloading when a matching Satori archive already exists. DownloadFile now targets a dated subfolder and only runs if the archive is missing; a SatoriDownloadedThisRun flag ensures the archive is only deleted when it was downloaded during this run. This reduces redundant downloads across builds and preserves existing archives.

@yair100 yair100 requested a review from hez2010 February 11, 2026 22:03
@yair100 yair100 added the ready for review Pull requests that are ready for review label Feb 11, 2026
Add date-based archive path and flags to skip downloading when a matching Satori archive already exists. DownloadFile now targets a dated subfolder and only runs if the archive is missing; a SatoriDownloadedThisRun flag ensures the archive is only deleted when it was downloaded during this run. This reduces redundant downloads across builds and preserves existing archives.
Co-authored-by: Steve <hez2010@outlook.com>
Signed-off-by: yair100 <39923744+yair100@users.noreply.github.com>
Copy link
Member

@hez2010 hez2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think cleaning up old Satori GC downloads is optional and can be done in the future if necessary.

@yair100
Copy link
Member Author

yair100 commented Feb 12, 2026

That's a good idea.

@yair100 yair100 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Feb 12, 2026
@yair100 yair100 merged commit eee6fa7 into main Feb 12, 2026
9 checks passed
@yair100 yair100 deleted the ya/Satori branch February 12, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants