removed boxed event handler references

Author: filipw

samples/csharp/autogen/Program.cs

@@ -5,9 +5,8 @@
 
 var cacheDir = Path.Combine(Directory.GetCurrentDirectory(), ".cache");
 
-var handler = new StreamingEventHandler();
 var modelBuilder = new PhiEngineBuilder();
-modelBuilder.WithEventHandler(new BoxedPhiEventHandler(handler));
+modelBuilder.WithEventHandler(new StreamingEventHandler());
 var model = modelBuilder.Build(cacheDir);
 
 var demo = AnsiConsole.Prompt(

samples/csharp/chatclient/Program.cs

@@ -5,9 +5,9 @@
 
 var cacheDir = Path.Combine(Directory.GetCurrentDirectory(), ".cache");
 
-var handler = new StreamingEventHandler();
+var handler = ;
 var modelBuilder = new PhiEngineBuilder();
-modelBuilder.WithEventHandler(new BoxedPhiEventHandler(handler));
+modelBuilder.WithEventHandler(new StreamingEventHandler());
 var model = modelBuilder.Build(cacheDir);
 
 var chatClient = model.AsChatClient("Local Phi-3 Demo", handler,

samples/ios/phi.engine.sample/phi.engine.sample/AiViewModel.swift

@@ -32,7 +32,7 @@ class Phi3ViewModel: ObservableObject {
         let modelProvider = PhiModelProvider.huggingFaceGguf(modelRepo: "microsoft/Phi-3-mini-4k-instruct-gguf", modelFileName: "Phi-3-mini-4k-instruct-q4.gguf", modelRevision: "main") 
         let engineBuilder = PhiEngineBuilder()
         try! engineBuilder.withModelProvider(modelProvider: modelProvider)
-        try! engineBuilder.withEventHandler(eventHandler: BoxedPhiEventHandler(handler: ModelEventsHandler(parent: self)))
+        try! engineBuilder.withEventHandler(eventHandler: ModelEventsHandler(parent: self))
 
         self.engine = try! engineBuilder.buildStateful(cacheDir: FileManager.default.temporaryDirectory.path(), systemInstruction: "You are a hockey wise old man. Share your wisdom briefly like an oracle. Be brief and to the point.")
         DispatchQueue.main.async {

samples/kotlin/main.kt

@@ -1,7 +1,6 @@
 import strathweb.phi.engine.InferenceOptionsBuilder
 import strathweb.phi.engine.PhiEventHandler
 import strathweb.phi.engine.PhiEngineBuilder
-import strathweb.phi.engine.BoxedPhiEventHandler
 import strathweb.phi.engine.PhiModelProvider
 import java.io.File
 
@@ -53,7 +52,7 @@ fun main(args: Array<String>) {
     }
 
     val modelBuilder = PhiEngineBuilder()
-    modelBuilder.withEventHandler(BoxedPhiEventHandler(ModelEventsHandler()))
+    modelBuilder.withEventHandler(ModelEventsHandler())
     modelBuilder.withModelProvider(modelProvider)
     val model = modelBuilder.buildStateful(cacheDir, "You are a hockey poet")
 

samples/python/console/main.py

@@ -26,7 +26,7 @@ def on_model_loaded(self):
 """)
 
 model_builder = PhiEngineBuilder()
-model_builder.with_event_handler(event_handler=BoxedPhiEventHandler(handler=ModelEventsHandler()))
+model_builder.with_event_handler(event_handler=ModelEventsHandler())
 gpu_enabled = model_builder.try_use_gpu()
 model = model_builder.build_stateful(cache_dir=cache_dir, system_instruction="You are a hockey poet")
 

samples/python/jupyter/demo.ipynb

@@ -52,7 +52,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 4,
+   "execution_count": null,
    "metadata": {},
    "outputs": [
     {
@@ -70,7 +70,7 @@
     "# Build the model\n",
     "# This might be slow when it downloads the model for the first time\n",
     "model_builder = PhiEngineBuilder()\n",
-    "model_builder.with_event_handler(event_handler=BoxedPhiEventHandler(handler=ModelEventsHandler()))\n",
+    "model_builder.with_event_handler(event_handler=ModelEventsHandler())\n",
     "gpu_enabled = model_builder.try_use_gpu()\n",
     "model = model_builder.build_stateful(cache_dir=cache_dir, system_instruction=\"You are a hockey poet\")"
    ]

samples/swift/main.swift

@@ -65,7 +65,7 @@ class ModelEventsHandler: PhiEventHandler {
 }
 
 let modelBuilder = PhiEngineBuilder()
-try! modelBuilder.withEventHandler(eventHandler: BoxedPhiEventHandler(handler: ModelEventsHandler()))
+try! modelBuilder.withEventHandler(eventHandler: ModelEventsHandler())
 try! modelBuilder.withModelProvider(modelProvider: modelProvider)
 
 if isPhi4 {

strathweb-phi-engine/src/engine.rs

@@ -163,16 +163,6 @@ pub trait PhiEventHandler: Send + Sync {
     fn on_inference_token(&self, token: String) -> Result<(), PhiError>;
 }
 
-// pub struct BoxedPhiEventHandler {
-//     pub handler: Box<dyn PhiEventHandler>,
-// }
-
-// impl BoxedPhiEventHandler {
-//     pub fn new(handler: Arc<dyn PhiEventHandler>) -> Self {
-//         Self { handler }
-//     }
-// }
-
 pub struct PhiEngineBuilder {
     inner: Mutex<PhiEngineBuilderInner>,
 }

strathweb-phi-engine/src/lib.rs

@@ -3,7 +3,6 @@ uniffi::include_scaffolding!("strathweb-phi-engine");
 use std::sync::atomic::AtomicBool;
 use std::sync::atomic::Ordering;
 
-// use crate::engine::BoxedPhiEventHandler;
 use crate::engine::ConversationContext;
 use crate::engine::ConversationMessage;
 use crate::engine::InferenceOptions;

strathweb-phi-engine/src/strathweb-phi-engine.udl

@@ -144,8 +144,6 @@ interface PhiEventHandler {
     void on_inference_ended();
 };
 
-
-
 [Error]
 interface PhiError {
     InitalizationError(string error_text);