Skip to content

Update IC-Light #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2024
Merged

Update IC-Light #403

merged 1 commit into from
Aug 21, 2024

Conversation

Laurent2916
Copy link
Contributor

@Laurent2916 Laurent2916 commented Aug 21, 2024 •
edited
Loading

  • Removed the use_rescaled_image argument of the set_ic_light_condition method
  • Improved docstrings + exposed them for mkdocstrings

@Laurent2916 Laurent2916 requested a review from deltheil August 21, 2024 08:35
@Laurent2916 Laurent2916 self-assigned this Aug 21, 2024
@Laurent2916 Laurent2916 mentioned this pull request Aug 21, 2024
Merged
deltheil
deltheil previously approved these changes Aug 21, 2024
View reviewed changes
deltheil
deltheil reviewed Aug 21, 2024
View reviewed changes
@Laurent2916 Laurent2916 force-pushed the pr/fix_test_ic_light branch from d576311 to f223b14 Compare August 21, 2024 10:20
@Laurent2916 Laurent2916 requested a review from deltheil August 21, 2024 10:21
@Laurent2916 Laurent2916 force-pushed the pr/fix_test_ic_light branch from f223b14 to d7bbf9a Compare August 21, 2024 10:21
@Laurent2916 Laurent2916 changed the title Fix broken test_ic_light Update IC-Light Aug 21, 2024
@Laurent2916 Laurent2916 merged commit a5d3c29 into main Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltheil deltheil deltheil approved these changes

Assignees

@Laurent2916 Laurent2916

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laurent2916 @deltheil