Skip to content

Conversation

kadirnar
Copy link
Contributor

@kadirnar kadirnar commented Aug 24, 2024

There is no documentation for Stable Diffusion(1.5). I have added an example code for this. Is there anything else you would like me to add?

@kadirnar
Copy link
Contributor Author

How do I solve this error?

pip install pyright
rye run pyright

Error Message:

error: invalid or unknown script 'pyright' 

@catwell
Copy link
Member

catwell commented Aug 26, 2024

How do I solve this error?

pip install pyright
rye run pyright

Error Message:

error: invalid or unknown script 'pyright' 

You are installing pyright with pip and then trying to use it with Rye, it will not work.

If you use rye, install pyright with rye (it does it automatically when you run rye sync --all-features). If you use pip, just run pyright and not rye run pyright.

@kadirnar
Copy link
Contributor Author

I ran this code and there was no change. Can you review it again?

rye run pyright

catwell
catwell previously approved these changes Aug 31, 2024
@catwell catwell added the run-ci Run CI label Aug 31, 2024
@catwell
Copy link
Member

catwell commented Aug 31, 2024

@kadirnar Can you squash all the commits into the first one?

I'd do it but with the way this repository is configured I cannot for external PRs like this one (because the main branch is protected and squash in the Git UI is disabled).

One way to do it is with interactive rebase, i.e. run git rebase -i HEAD~10 and turn the last 5 commits into fixups like in the screenshot below, then force push to the branch.

Screenshot from 2024-08-31 11-25-25

@kadirnar
Copy link
Contributor Author

kadirnar commented Sep 5, 2024

I rolled back the previous commits and fixed them manually. Can you check?

@catwell catwell self-requested a review September 6, 2024 07:06
@catwell catwell added run-ci Run CI and removed run-ci Run CI labels Sep 6, 2024
@catwell catwell merged commit 5aef140 into finegrain-ai:main Sep 6, 2024
2 checks passed
@catwell
Copy link
Member

catwell commented Sep 6, 2024

It's merged, thanks!

@kadirnar kadirnar deleted the sd15_docstr branch September 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-ci Run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants