Skip to content

Conversation

Laurent2916
Copy link
Contributor

@Laurent2916 Laurent2916 commented Sep 5, 2024

Well it looks like #423 doesn't work:

comfy node registry-install comfyui-manager
...
CalledProcessError: Command '['/home/laurent/github.com/comfyanonymous/ComfyUI/.venv2/bin/python3.12', '-m', 'pip', 'install', '-e file:.']' returned non-zero exit status 1.

I think this is because they basically do

cat requirements.txt | xargs -i pip install {}

and because -e file:. is obviously an incorrect argument (it should be split in two).

Anyway, let's hardcode the actual deps into the requirements.txt and pray that they will also support using the deps directly inside the pyproject.toml in the future.

@Laurent2916 Laurent2916 requested a review from deltheil September 5, 2024 14:44
@Laurent2916 Laurent2916 self-assigned this Sep 5, 2024
@Laurent2916 Laurent2916 changed the title comfyui nodes fix requirements.txt comfyui-refiners fix requirements.txt Sep 5, 2024
@Laurent2916 Laurent2916 merged commit cf247a1 into main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants