This repository was archived by the owner on Sep 26, 2025. It is now read-only.
MultiUpscaler: improve resizing logic #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
catwell
commented
Sep 6, 2024
catwell
commented
- Do not have a parameter to downscale (caller can do it beforehand if they want).
- Do not enforce mod 8 before upscale, we need it afterwards only (before SD).
catwell
force-pushed
the
pr/upscaler-tweaks
branch
from
9b1e037 to
c332605
Compare
deltheil
reviewed
Sep 6, 2024
src/refiners/foundationals/latent_diffusion/stable_diffusion_1/multi_upscaler.py
Outdated
Show resolved
Hide resolved
catwell
force-pushed
the
pr/upscaler-tweaks
branch
from
c332605 to
b707aaf
Compare
- Do not have a parameter to downscale (caller can do it beforehand if they want). - Do not enforce mod 8 *before* upscale, we need it afterwards only (before SD).
catwell
force-pushed
the
pr/upscaler-tweaks
branch
from
b707aaf to
558f927
Compare
deltheil
approved these changes
Sep 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.