Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Loosen the tolerances for some SAM tests #433

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Loosen the tolerances for some SAM tests #433

merged 1 commit into from
Sep 9, 2024

Conversation

Laurent2916
Copy link
Contributor

Because of a recent pytorch upgrade:

FAILED tests/foundationals/segment_anything/test_hq_sam.py::test_predictor[False] - assert tensor(2.) <= 1
FAILED tests/foundationals/segment_anything/test_sam.py::test_predictor_single_output - AssertionError: assert False
FAILED tests/foundationals/segment_anything/test_sam.py::test_mask_encoder - AssertionError: assert False

I've increase the atol of the failing tests (not ideal i know)

@Laurent2916 Laurent2916 requested a review from deltheil September 9, 2024 15:00
@Laurent2916 Laurent2916 self-assigned this Sep 9, 2024
@Laurent2916 Laurent2916 force-pushed the pr/loosen_some_failing_sam_tests branch from 991cb4d to fc3a74e Compare September 9, 2024 15:10
@Laurent2916 Laurent2916 merged commit 6d58492 into main Sep 9, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@deltheil deltheil deltheil approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Laurent2916 Laurent2916

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laurent2916 @deltheil