Drop visitorId check and refactor functional tests #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validate `FPJS_API_SECRET` environment. Normalize region env variable. Remove unused `ApiClient` import. Simplify `FingerprintApi` build. Replace global `FPJS_*` with local variables. Add null-safety assertions. Minor readability tweaks. Related-Task: INTER-1473
erayaydin
requested review from
Orkuncakilkaya,
ilfa,
mcnulty-fp and
necipallef
as code owners
mcnulty-fp
previously approved these changes
Sep 29, 2025
Contributor
mcnulty-fp
left a comment
mcnulty-fp
left a comment
There was a problem hiding this comment.
LGTM! One minor comment about enabling assertions to fail the FunctionalTests when the assertions fail.
Add `-ea` jvm args to the `runFunctionalTests`. Related-Task: INTER-1473
Contributor
pnpm exec changesetto create a changeset. |
mcnulty-fp
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the functional test script simpler. We no longer compare
visitorIdbetween recent and oldest events.✏️ What Changed?
requestIdonly (removedvisitorIdcheck) so repeated visitors don't fail the check.FPJS_API_SECRETenv variable at startup. Fail fast if missing.FPJS_API_REGIONenv reading.ApiClientimport.FPJS_*with local variables.